From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Alonso <martin.alonso@zoho.com>
Cc: joe@perches.com, forest@alittletooquiet.net, pasteka@kabsi.at,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 *
Date: Wed, 28 Sep 2016 11:34:59 +0200 [thread overview]
Message-ID: <20160928093459.GA392@kroah.com> (raw)
In-Reply-To: <1474998769-29646-2-git-send-email-martin.alonso@zoho.com>
On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote:
> Change the type and uses of rx_rate.
That's totally vague and doesn't say why this patch is needed at all.
For all I can tell, it looks like you are changing the type for no good
reason...
Please fix this up and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-28 9:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 17:48 [PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso
2016-09-26 18:02 ` Joe Perches
2016-09-27 16:59 ` Martin Alonso
2016-09-27 17:52 ` [PATCH 1/2] staging: vt6656: Remove unused variable 'rx_sts' Martin Alonso
2016-09-27 17:52 ` [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Martin Alonso
2016-09-28 7:40 ` Dan Carpenter
2016-09-30 18:53 ` Malcolm Priestley
2016-09-30 19:37 ` Dan Carpenter
2016-09-28 9:34 ` Greg KH [this message]
2016-09-27 11:10 ` [PATCH] staging: vt6656: Add spaces around '+' operator Greg KH
2016-09-27 11:49 ` Martin Alonso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928093459.GA392@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.alonso@zoho.com \
--cc=pasteka@kabsi.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.