From: Vinod Koul <vinod.koul@intel.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dan.j.williams@intel.com, arnd@arndb.de,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tony@atomide.com
Subject: Re: [PATCH v3 6/9] dmaengine: ti-dma-crossbar: Fix of_device_id data parameter usage
Date: Wed, 28 Sep 2016 08:47:10 +0530 [thread overview]
Message-ID: <20160928031709.GJ2467@localhost> (raw)
In-Reply-To: <20160921124135.11849-7-peter.ujfalusi@ti.com>
On Wed, Sep 21, 2016 at 03:41:32PM +0300, Peter Ujfalusi wrote:
> @@ -395,7 +403,7 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
>
> xbar->dmarouter.dev = &pdev->dev;
> xbar->dmarouter.route_free = ti_dra7_xbar_free;
> - xbar->dma_offset = (u32)match->data;
> + xbar->dma_offset = *(u32*)match->data;
^^^^
we need space between u32 and *
> mutex_init(&xbar->mutex);
> platform_set_drvdata(pdev, xbar);
> @@ -428,7 +436,7 @@ static int ti_dma_xbar_probe(struct platform_device *pdev)
> if (unlikely(!match))
> return -EINVAL;
>
> - switch ((u32)match->data) {
> + switch (*(u32*)match->data) {
here too please
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/9] dmaengine: ti-dma-crossbar: Fix of_device_id data parameter usage
Date: Wed, 28 Sep 2016 08:47:10 +0530 [thread overview]
Message-ID: <20160928031709.GJ2467@localhost> (raw)
In-Reply-To: <20160921124135.11849-7-peter.ujfalusi@ti.com>
On Wed, Sep 21, 2016 at 03:41:32PM +0300, Peter Ujfalusi wrote:
> @@ -395,7 +403,7 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
>
> xbar->dmarouter.dev = &pdev->dev;
> xbar->dmarouter.route_free = ti_dra7_xbar_free;
> - xbar->dma_offset = (u32)match->data;
> + xbar->dma_offset = *(u32*)match->data;
^^^^
we need space between u32 and *
> mutex_init(&xbar->mutex);
> platform_set_drvdata(pdev, xbar);
> @@ -428,7 +436,7 @@ static int ti_dma_xbar_probe(struct platform_device *pdev)
> if (unlikely(!match))
> return -EINVAL;
>
> - switch ((u32)match->data) {
> + switch (*(u32*)match->data) {
here too please
--
~Vinod
next prev parent reply other threads:[~2016-09-28 3:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 12:41 [PATCH v3 0/9] dmaengine: ti drivers: enable COMPILE_TESTing Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` [PATCH v3 1/9] dmaengine: edma: Add missing MODULE_DEVICE_TABLE() for of_device_id structs Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` [PATCH v3 2/9] dmaengine: edma: Fix of_device_id data parameter usage (legacy vs TPCC) Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` [PATCH v3 3/9] dmaengine: edma: Use correct type for of_find_property() third parameter Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` [PATCH v3 4/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile test on non OMAP configs Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` [PATCH v3 5/9] dmaengine: ti-dma-crossbar: Correct type for of_find_property() third parameter Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` [PATCH v3 6/9] dmaengine: ti-dma-crossbar: Fix of_device_id data parameter usage Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-28 3:17 ` Vinod Koul [this message]
2016-09-28 3:17 ` Vinod Koul
2016-09-21 12:41 ` [PATCH v3 7/9] dmaengine: edma: enable COMPILE_TEST Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-22 4:50 ` kbuild test robot
2016-09-22 4:50 ` kbuild test robot
2016-09-21 12:41 ` [PATCH v3 8/9] dmaengine: omap-dma: " Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` [PATCH v3 9/9] dmaengine: ti-dma-crossbar: " Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-21 12:41 ` Peter Ujfalusi
2016-09-28 3:26 ` [PATCH v3 0/9] dmaengine: ti drivers: enable COMPILE_TESTing Vinod Koul
2016-09-28 3:26 ` Vinod Koul
2016-09-28 5:58 ` Peter Ujfalusi
2016-09-28 5:58 ` Peter Ujfalusi
2016-09-28 5:58 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928031709.GJ2467@localhost \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.