All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/sun4i: rgb: Enable panel after controller
Date: Thu, 29 Sep 2016 14:04:45 +0200	[thread overview]
Message-ID: <20160929120445.GQ4189@lukather> (raw)
In-Reply-To: <CAOw6vbKxJeSZYsCwVWYbVosZUK+FfBq1ytrpRUNpbH+kM6Ow6Q@mail.gmail.com>

Hi,

On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote:
> As an aside, it seems like (from the diff, I haven't looked at the
> code) the bridge_pre_enable and bridge_post_disable calls are missing,
> and the enable/disable calls are in the wrong place.

Actually, I don't even think that's necessary. The atomic helpers
already call drm_bridge_pre_enable and drm_bridge_enable at the right
time. So I guess the proper fix would be to just remove the driver's
call to drm_bridge_enable.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160929/7c5646a7/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Jonathan Liu <net147@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/sun4i: rgb: Enable panel after controller
Date: Thu, 29 Sep 2016 14:04:45 +0200	[thread overview]
Message-ID: <20160929120445.GQ4189@lukather> (raw)
In-Reply-To: <CAOw6vbKxJeSZYsCwVWYbVosZUK+FfBq1ytrpRUNpbH+kM6Ow6Q@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 628 bytes --]

Hi,

On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote:
> As an aside, it seems like (from the diff, I haven't looked at the
> code) the bridge_pre_enable and bridge_post_disable calls are missing,
> and the enable/disable calls are in the wrong place.

Actually, I don't even think that's necessary. The atomic helpers
already call drm_bridge_pre_enable and drm_bridge_enable at the right
time. So I guess the proper fix would be to just remove the driver's
call to drm_bridge_enable.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: Jonathan Liu <net147@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/sun4i: rgb: Enable panel after controller
Date: Thu, 29 Sep 2016 14:04:45 +0200	[thread overview]
Message-ID: <20160929120445.GQ4189@lukather> (raw)
In-Reply-To: <CAOw6vbKxJeSZYsCwVWYbVosZUK+FfBq1ytrpRUNpbH+kM6Ow6Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hi,

On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote:
> As an aside, it seems like (from the diff, I haven't looked at the
> code) the bridge_pre_enable and bridge_post_disable calls are missing,
> and the enable/disable calls are in the wrong place.

Actually, I don't even think that's necessary. The atomic helpers
already call drm_bridge_pre_enable and drm_bridge_enable at the right
time. So I guess the proper fix would be to just remove the driver's
call to drm_bridge_enable.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-09-29 12:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 13:03 [PATCH] drm/sun4i: rgb: Enable panel after controller Jonathan Liu
2016-09-21 13:03 ` Jonathan Liu
2016-09-21 21:03 ` Maxime Ripard
2016-09-21 21:03   ` Maxime Ripard
2016-09-21 21:03   ` Maxime Ripard
2016-09-21 22:03   ` Jonathan Liu
2016-09-23 13:16     ` Maxime Ripard
2016-09-23 13:16       ` Maxime Ripard
2016-09-23 13:16       ` Maxime Ripard
2016-09-23 13:43       ` Jonathan Liu
2016-09-23 13:43         ` Jonathan Liu
2016-09-24 20:18         ` Maxime Ripard
2016-09-24 20:18           ` Maxime Ripard
2016-09-24 20:18           ` Maxime Ripard
2016-09-27 14:42           ` Sean Paul
2016-09-27 14:42             ` Sean Paul
2016-09-27 14:42             ` Sean Paul
2016-09-28 21:17             ` Maxime Ripard
2016-09-28 21:17               ` Maxime Ripard
2016-09-28 21:17               ` Maxime Ripard
2016-09-29 12:04             ` Maxime Ripard [this message]
2016-09-29 12:04               ` Maxime Ripard
2016-09-29 12:04               ` Maxime Ripard
2016-09-29 17:29               ` Sean Paul
2016-09-29 17:29                 ` Sean Paul
2016-09-29 17:29                 ` Sean Paul
2016-09-21 22:06   ` Jonathan Liu
2016-09-21 22:06     ` Jonathan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929120445.GQ4189@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.