From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH 2/2] net/virtio: enable any layout feature
Date: Thu, 29 Sep 2016 21:00:47 +0300 [thread overview]
Message-ID: <20160929205815-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1474872056-24665-3-git-send-email-yuanhan.liu@linux.intel.com>
On Mon, Sep 26, 2016 at 02:40:56PM +0800, Yuanhan Liu wrote:
> The feature VIRTIO_F_ANY_LAYOUT was actually supported by commit
> dd856dfcb9e7 ("virtio: use any layout on Tx"). But it's not enabled.
> Here this patch enables it.
>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Well this will break cross-version migration if just done
unconditionally.
Let's add a protocol feature for this bugfix?
> ---
> drivers/net/virtio/virtio_ethdev.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h
> index 04d626b..3e31e6a 100644
> --- a/drivers/net/virtio/virtio_ethdev.h
> +++ b/drivers/net/virtio/virtio_ethdev.h
> @@ -64,6 +64,7 @@
> 1u << VIRTIO_NET_F_CTRL_VLAN | \
> 1u << VIRTIO_NET_F_MRG_RXBUF | \
> 1u << VIRTIO_RING_F_INDIRECT_DESC | \
> + 1u << VIRTIO_F_ANY_LAYOUT | \
> 1ULL << VIRTIO_F_VERSION_1)
>
> /*
> --
> 1.9.0
next prev parent reply other threads:[~2016-09-29 18:00 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 6:40 [PATCH 0/2] enables vhost/virtio any layout feature Yuanhan Liu
2016-09-26 6:40 ` [PATCH 1/2] vhost: enable " Yuanhan Liu
2016-09-26 18:01 ` Stephen Hemminger
2016-09-26 19:24 ` Michael S. Tsirkin
2016-09-26 19:24 ` [Qemu-devel] " Michael S. Tsirkin
2016-09-27 3:11 ` Yuanhan Liu
2016-09-27 3:11 ` [Qemu-devel] " Yuanhan Liu
2016-09-27 19:48 ` Stephen Hemminger
2016-09-27 19:48 ` [Qemu-devel] " Stephen Hemminger
2016-09-27 19:56 ` Michael S. Tsirkin
2016-09-27 19:56 ` [Qemu-devel] " Michael S. Tsirkin
2016-09-28 2:28 ` Yuanhan Liu
2016-09-28 2:28 ` [Qemu-devel] " Yuanhan Liu
2016-09-29 15:30 ` Maxime Coquelin
2016-09-29 17:57 ` Michael S. Tsirkin
2016-09-29 20:05 ` Maxime Coquelin
2016-09-29 20:21 ` Michael S. Tsirkin
2016-09-29 21:23 ` Maxime Coquelin
2016-09-30 12:05 ` Maxime Coquelin
2016-09-30 19:16 ` Michael S. Tsirkin
2016-10-10 4:05 ` Yuanhan Liu
2016-10-10 4:17 ` Michael S. Tsirkin
2016-10-10 4:22 ` Yuanhan Liu
2016-10-10 4:25 ` Michael S. Tsirkin
2016-10-10 12:40 ` Maxime Coquelin
2016-10-10 14:42 ` Yuanhan Liu
2016-10-10 14:54 ` Maxime Coquelin
2016-10-11 6:04 ` Yuanhan Liu
2016-10-11 6:39 ` Maxime Coquelin
2016-10-11 6:49 ` Yuanhan Liu
2016-10-03 14:20 ` Maxime Coquelin
2016-10-10 3:37 ` Yuanhan Liu
2016-10-10 3:46 ` Michael S. Tsirkin
2016-10-10 3:59 ` Yuanhan Liu
2016-10-10 4:16 ` Wang, Zhihong
2016-10-10 4:24 ` Michael S. Tsirkin
2016-10-10 4:39 ` Michael S. Tsirkin
2016-10-11 6:57 ` Yuanhan Liu
2016-10-12 3:21 ` Yuanhan Liu
2016-10-12 3:21 ` [Qemu-devel] [dpdk-dev] " Yuanhan Liu
[not found] ` <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16C2409EB@SHSMSX101.ccr.corp.intel.com>
2016-10-13 2:52 ` [Qemu-devel] " Yang, Zhiyong
2016-10-13 2:52 ` [Qemu-devel] [dpdk-dev] " Yang, Zhiyong
2016-10-10 3:50 ` [Qemu-devel] " Yuanhan Liu
2016-10-09 23:20 ` Michael S. Tsirkin
2016-10-09 23:20 ` [Qemu-devel] " Michael S. Tsirkin
2016-10-10 3:03 ` Yuanhan Liu
2016-10-10 3:03 ` [Qemu-devel] " Yuanhan Liu
2016-10-10 3:04 ` Michael S. Tsirkin
2016-10-10 3:04 ` [Qemu-devel] " Michael S. Tsirkin
2016-10-10 3:10 ` Yuanhan Liu
2016-10-10 3:10 ` [Qemu-devel] " Yuanhan Liu
2016-09-26 6:40 ` [PATCH 2/2] net/virtio: " Yuanhan Liu
2016-09-26 18:04 ` Stephen Hemminger
2016-09-29 18:00 ` Michael S. Tsirkin [this message]
2016-09-29 18:01 ` Michael S. Tsirkin
2016-11-10 15:18 ` [PATCH 0/2] enables vhost/virtio " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929205815-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stephen@networkplumber.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.