From: Dan Carpenter <dan.carpenter@oracle.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [bug report] i40e: Fix kernel panic on enable/disable LLDP
Date: Fri, 30 Sep 2016 13:41:01 +0300 [thread overview]
Message-ID: <20160930104101.GA10918@mwanda> (raw)
Hello Dave Ertman,
The patch a036244c0686: "i40e: Fix kernel panic on enable/disable
LLDP" from Aug 29, 2016, leads to the following static checker
warning:
drivers/net/ethernet/intel/i40e/i40e_main.c:10958 i40e_probe()
warn: odd binop '0x20000000 & 0x100000'
drivers/net/ethernet/intel/i40e/i40e_main.c
10952 pci_set_drvdata(pdev, pf);
10953 pci_save_state(pdev);
10954 #ifdef CONFIG_I40E_DCB
10955 err = i40e_init_pf_dcb(pf);
10956 if (err) {
10957 dev_info(&pdev->dev, "DCB init failed %d, disabled\n", err);
10958 pf->flags &= ~(I40E_FLAG_DCB_CAPABLE & I40E_FLAG_DCB_ENABLED);
Should this be an | instead of an &? The current code is a no-op.
10959 /* Continue without DCB enabled */
10960 }
10961 #endif /* CONFIG_I40E_DCB */
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] i40e: Fix kernel panic on enable/disable LLDP
Date: Fri, 30 Sep 2016 10:41:01 +0000 [thread overview]
Message-ID: <20160930104101.GA10918@mwanda> (raw)
Hello Dave Ertman,
The patch a036244c0686: "i40e: Fix kernel panic on enable/disable
LLDP" from Aug 29, 2016, leads to the following static checker
warning:
drivers/net/ethernet/intel/i40e/i40e_main.c:10958 i40e_probe()
warn: odd binop '0x20000000 & 0x100000'
drivers/net/ethernet/intel/i40e/i40e_main.c
10952 pci_set_drvdata(pdev, pf);
10953 pci_save_state(pdev);
10954 #ifdef CONFIG_I40E_DCB
10955 err = i40e_init_pf_dcb(pf);
10956 if (err) {
10957 dev_info(&pdev->dev, "DCB init failed %d, disabled\n", err);
10958 pf->flags &= ~(I40E_FLAG_DCB_CAPABLE & I40E_FLAG_DCB_ENABLED);
Should this be an | instead of an &? The current code is a no-op.
10959 /* Continue without DCB enabled */
10960 }
10961 #endif /* CONFIG_I40E_DCB */
regards,
dan carpenter
next reply other threads:[~2016-09-30 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 10:41 Dan Carpenter [this message]
2016-09-30 10:41 ` [bug report] i40e: Fix kernel panic on enable/disable LLDP Dan Carpenter
2016-09-30 16:43 ` [Intel-wired-lan] " Ertman, David M
2016-09-30 16:43 ` Ertman, David M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930104101.GA10918@mwanda \
--to=dan.carpenter@oracle.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.