From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][V2] dmaengine: coh901318: fix integer overflow when shifting more than 32 places
Date: Fri, 30 Sep 2016 23:19:11 +0530 [thread overview]
Message-ID: <20160930174911.GW2467@localhost> (raw)
In-Reply-To: <20160929181438.14374-1-colin.king@canonical.com>
On Thu, Sep 29, 2016 at 07:14:38PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
> be more than 32 places, which leads to a 32 bit integer overflow. Fix this
> by using 1ULL instead of 1 before shifting it. Also add braces on the
> for-loop to keep with coding style conventions.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] dmaengine: coh901318: fix integer overflow when shifting more than 32 places
Date: Fri, 30 Sep 2016 23:19:11 +0530 [thread overview]
Message-ID: <20160930174911.GW2467@localhost> (raw)
In-Reply-To: <20160929181438.14374-1-colin.king@canonical.com>
On Thu, Sep 29, 2016 at 07:14:38PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
> be more than 32 places, which leads to a 32 bit integer overflow. Fix this
> by using 1ULL instead of 1 before shifting it. Also add braces on the
> for-loop to keep with coding style conventions.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2016-09-30 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 18:14 [PATCH][V2] dmaengine: coh901318: fix integer overflow when shifting more than 32 places Colin King
2016-09-29 18:14 ` Colin King
2016-09-30 17:49 ` Vinod Koul [this message]
2016-09-30 17:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930174911.GW2467@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.