From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2 v2] f2fs: use crc and cp version to determine roll-forward recovery
Date: Fri, 30 Sep 2016 17:54:49 -0700 [thread overview]
Message-ID: <20161001005449.GA63648@jaegeuk> (raw)
In-Reply-To: <5758dbdd-610e-64cf-3cef-44794e5b32b4@kernel.org>
On Sat, Oct 01, 2016 at 08:26:20AM +0800, Chao Yu wrote:
> On 2016/10/1 1:10, Jaegeuk Kim wrote:
> > @@ -1089,6 +1079,9 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> > if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
> > set_ckpt_flags(ckpt, CP_FSCK_FLAG);
> >
> > + /* set this flag to activate crc|cp_ver for recovery */
> > + set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG);
>
> Should let new introduced spinlock cover the flag updating in ("f2fs: introduce
> cp_lock to protect updating of ckpt_flags").
Fixed.
http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=aaec2b1d18792a5f27b69ff37f34f43f89f5aa3b
Thank you. :)
>
> Thanks,
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to determine roll-forward recovery
Date: Fri, 30 Sep 2016 17:54:49 -0700 [thread overview]
Message-ID: <20161001005449.GA63648@jaegeuk> (raw)
In-Reply-To: <5758dbdd-610e-64cf-3cef-44794e5b32b4@kernel.org>
On Sat, Oct 01, 2016 at 08:26:20AM +0800, Chao Yu wrote:
> On 2016/10/1 1:10, Jaegeuk Kim wrote:
> > @@ -1089,6 +1079,9 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> > if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
> > set_ckpt_flags(ckpt, CP_FSCK_FLAG);
> >
> > + /* set this flag to activate crc|cp_ver for recovery */
> > + set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG);
>
> Should let new introduced spinlock cover the flag updating in ("f2fs: introduce
> cp_lock to protect updating of ckpt_flags").
Fixed.
http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=aaec2b1d18792a5f27b69ff37f34f43f89f5aa3b
Thank you. :)
>
> Thanks,
next prev parent reply other threads:[~2016-10-01 0:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 2:55 [PATCH 1/2] f2fs: use crc and cp version to determine roll-forward recovery Jaegeuk Kim
2016-09-20 2:55 ` [PATCH 2/2] f2fs: put directory inodes before checkpoint in " Jaegeuk Kim
2016-09-20 2:55 ` Jaegeuk Kim
2016-09-20 15:48 ` [f2fs-dev] [PATCH 1/2] f2fs: use crc and cp version to determine " Chao Yu
2016-09-21 0:45 ` Jaegeuk Kim
2016-09-24 6:00 ` Chao Yu
2016-09-24 6:00 ` [f2fs-dev] " Chao Yu
2016-09-24 18:20 ` Jaegeuk Kim
2016-09-29 12:01 ` Chao Yu
2016-09-29 12:01 ` Chao Yu
2016-09-30 0:53 ` Jaegeuk Kim
2016-09-30 0:53 ` Jaegeuk Kim
2016-09-30 1:04 ` Chao Yu
2016-09-30 1:04 ` Chao Yu
2016-09-30 17:10 ` [PATCH 1/2 v2] " Jaegeuk Kim
2016-10-01 0:26 ` Chao Yu
2016-10-01 0:26 ` [f2fs-dev] " Chao Yu
2016-10-01 0:54 ` Jaegeuk Kim [this message]
2016-10-01 0:54 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161001005449.GA63648@jaegeuk \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.