From: Greg Kurz <groug@kaod.org>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org, dgibson@redhat.com, thuth@redhat.com,
qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/5] tests: fix memory leak in virtio-scsi-test
Date: Sun, 2 Oct 2016 10:30:51 +0200 [thread overview]
Message-ID: <20161002103051.4aa295c6@bahia> (raw)
In-Reply-To: <1475348164-8593-2-git-send-email-lvivier@redhat.com>
On Sat, 1 Oct 2016 20:56:00 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> vs is allocated in qvirtio_scsi_pci_init() and never freed.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> tests/virtio-scsi-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
> index 79088bb..94d75b1 100644
> --- a/tests/virtio-scsi-test.c
> +++ b/tests/virtio-scsi-test.c
> @@ -64,6 +64,7 @@ static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs)
> qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, vdev));
> g_free(vs->dev);
> qpci_free_pc(vs->bus);
> + g_free(vs);
> }
>
> static uint64_t qvirtio_scsi_alloc(QVirtIOSCSI *vs, size_t alloc_size,
next prev parent reply other threads:[~2016-10-02 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 18:55 [Qemu-devel] [PATCH v3 0/5] tests: enable virtio tests on SPAPR Laurent Vivier
2016-10-01 18:56 ` [Qemu-devel] [PATCH v3 1/5] tests: fix memory leak in virtio-scsi-test Laurent Vivier
2016-10-02 8:30 ` Greg Kurz [this message]
2016-10-01 18:56 ` [Qemu-devel] [PATCH v3 2/5] tests: don't check if qtest_spapr_boot() returns NULL Laurent Vivier
2016-10-02 8:32 ` Greg Kurz
2016-10-01 18:56 ` [Qemu-devel] [PATCH v3 3/5] tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests Laurent Vivier
2016-10-07 16:38 ` Greg Kurz
2016-10-07 17:54 ` Laurent Vivier
2016-10-14 8:11 ` Greg Kurz
2016-10-14 8:34 ` Laurent Vivier
2016-10-01 18:56 ` [Qemu-devel] [PATCH v3 4/5] qtest: evaluate endianness of the target in qtest_init() Laurent Vivier
2016-10-01 18:56 ` [Qemu-devel] [PATCH v3 5/5] tests: enable virtio tests on SPAPR Laurent Vivier
2016-10-02 8:36 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002103051.4aa295c6@bahia \
--to=groug@kaod.org \
--cc=dgibson@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.