From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org
Subject: Re: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()
Date: Mon, 3 Oct 2016 09:39:46 -0700 [thread overview]
Message-ID: <20161003163946.GA19832@infradead.org> (raw)
In-Reply-To: <20161003144246.GA14183-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
On Mon, Oct 03, 2016 at 04:42:46PM +0200, Jan Kara wrote:
> Ah, you are right. After reading the code again this patch is not needed
> anymore because xfs_file_iomap_begin() returns IOMAP_F_NEW whenever we
> allocated block regardless whether it was zeroed-out or not. But if I get it
> right, all the IS_DAX checks in __xfs_get_blocks() can be dropped now, cannot
> they?
Right now the code is required to keep the pmd_fault handler (which
is always disabled though) compiling. Once that one is gone the
DAX code in __xfs_get_blocks can be removed. In fact Ross sent a
patch to do just that as part of his PMD fault rework.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-nvdimm@ml01.01.org,
Dan Williams <dan.j.williams@intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()
Date: Mon, 3 Oct 2016 09:39:46 -0700 [thread overview]
Message-ID: <20161003163946.GA19832@infradead.org> (raw)
In-Reply-To: <20161003144246.GA14183@quack2.suse.cz>
On Mon, Oct 03, 2016 at 04:42:46PM +0200, Jan Kara wrote:
> Ah, you are right. After reading the code again this patch is not needed
> anymore because xfs_file_iomap_begin() returns IOMAP_F_NEW whenever we
> allocated block regardless whether it was zeroed-out or not. But if I get it
> right, all the IS_DAX checks in __xfs_get_blocks() can be dropped now, cannot
> they?
Right now the code is required to keep the pmd_fault handler (which
is always disabled though) compiling. Once that one is gone the
DAX code in __xfs_get_blocks can be removed. In fact Ross sent a
patch to do just that as part of his PMD fault rework.
next prev parent reply other threads:[~2016-10-03 16:39 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 16:43 [PATCH 0/6] dax: Page invalidation fixes Jan Kara
2016-09-27 16:43 ` Jan Kara
2016-09-27 16:43 ` [PATCH 1/6] dax: Do not warn about BH_New buffers Jan Kara
2016-09-27 16:43 ` Jan Kara
[not found] ` <1474994615-29553-2-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30 8:53 ` Christoph Hellwig
2016-09-30 8:53 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 2/6] ext2: Return BH_New buffers for zeroed blocks Jan Kara
2016-09-27 16:43 ` Jan Kara
[not found] ` <1474994615-29553-3-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30 8:53 ` Christoph Hellwig
2016-09-30 8:53 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 3/6] ext4: Remove clearing of BH_New bit " Jan Kara
2016-09-27 16:43 ` Jan Kara
[not found] ` <1474994615-29553-4-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30 8:53 ` Christoph Hellwig
2016-09-30 8:53 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks() Jan Kara
2016-09-27 16:43 ` Jan Kara
[not found] ` <1474994615-29553-5-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-27 17:01 ` Christoph Hellwig
2016-09-27 17:01 ` Christoph Hellwig
2016-09-27 17:17 ` Jan Kara
2016-09-28 0:22 ` Dave Chinner
2016-10-03 14:44 ` Jan Kara
2016-10-03 14:44 ` Jan Kara
[not found] ` <20160927171707.GA30327-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-09-28 2:13 ` Christoph Hellwig
2016-09-28 2:13 ` Christoph Hellwig
2016-10-03 14:42 ` Jan Kara
[not found] ` <20161003144246.GA14183-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-10-03 16:39 ` Christoph Hellwig [this message]
2016-10-03 16:39 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 5/6] mm: Invalidate DAX radix tree entries only if appropriate Jan Kara
2016-09-27 16:43 ` Jan Kara
2016-09-28 0:18 ` Dave Chinner
2016-09-28 0:18 ` Dave Chinner
2016-10-03 14:52 ` Jan Kara
2016-10-03 14:52 ` Jan Kara
[not found] ` <1474994615-29553-6-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30 8:57 ` Christoph Hellwig
2016-09-30 8:57 ` Christoph Hellwig
2016-10-03 12:56 ` Jan Kara
2016-09-27 16:43 ` [PATCH 6/6] dax: Avoid page invalidation races and unnecessary radix tree traversals Jan Kara
2016-09-27 16:43 ` Jan Kara
2016-09-28 0:20 ` Dave Chinner
2016-09-28 0:20 ` Dave Chinner
2016-10-03 14:58 ` Jan Kara
2016-10-03 14:58 ` Jan Kara
2016-10-03 23:40 ` Dave Chinner
2016-10-03 23:40 ` Dave Chinner
[not found] ` <1474994615-29553-7-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30 8:55 ` Christoph Hellwig
2016-09-30 8:55 ` Christoph Hellwig
[not found] ` <20160930085544.GD22381-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-10-03 15:02 ` Jan Kara
2016-10-03 15:02 ` Jan Kara
[not found] ` <1474994615-29553-1-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30 8:59 ` [PATCH 0/6] dax: Page invalidation fixes Christoph Hellwig
2016-09-30 8:59 ` Christoph Hellwig
2016-10-03 13:01 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003163946.GA19832@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.