trailing comma in parameter list

trailing comma in parameter list

[Elizabeth Ferdman]

A question just came up after seeing this checkpatch error:

ERROR: space prohibited before that close parenthesis ')'
#71: FILE:
/home/lizadev/git/kernels/staging/drivers/staging/fbtft/fbtft-bus.c:71:
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )

I'm wondering why there's a comma after the last parameter. I found
something about variadic macros on gcc.gnu.org. Not seeing how that
applies here though...

I wonder if taking out that space would be a problem. 

-liz

Re: [Outreachy kernel] trailing comma in parameter list

[Julia Lawall]

On Mon, 3 Oct 2016, Elizabeth Ferdman wrote:

> A question just came up after seeing this checkpatch error:
>
> ERROR: space prohibited before that close parenthesis ')'
> #71: FILE:
> /home/lizadev/git/kernels/staging/drivers/staging/fbtft/fbtft-bus.c:71:
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
>
> I'm wondering why there's a comma after the last parameter. I found
> something about variadic macros on gcc.gnu.org. Not seeing how that
> applies here though...

II haven't looked at the definition, but I would guess it is something
that can be empty.

>
> I wonder if taking out that space would be a problem.

I think that the space improves readability.

julia

> -liz
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161003215732.GA4343%40localhost.
> For more options, visit https://groups.google.com/d/optout.
>