From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Keila Novo <laurana5@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH]board/Kconfig: Add a paragraph that describes the simbol
Date: Tue, 4 Oct 2016 06:23:23 +0200 [thread overview]
Message-ID: <20161004042323.GB21357@kroah.com> (raw)
In-Reply-To: <20160929152837.GA32652@kheixx-VB>
On Thu, Sep 29, 2016 at 05:28:37PM +0200, Keila Novo wrote:
>
> Commit:
What is that line for?
> The staging board allows continous upstream
> in-tree development and integration of
> new platform devices.
You have trailing whitespace, and you wrapped your paragraph at an odd
line length, why?
>
> Signed-off-by: Keila Novo <laurana5@gmail.com>
> ---
> drivers/staging/board/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/board/Kconfig b/drivers/staging/board/Kconfig
> index 3f287c4..830337d 100644
> --- a/drivers/staging/board/Kconfig
> +++ b/drivers/staging/board/Kconfig
> @@ -1,3 +1,7 @@
> +#
> +#Staging board gives support and configures the kernel build
> +#with new type of devices, making them compatible.
> +#
I don't understand that sentence at all, could you rephrase it somehow?
And why not an extra ' ' after the comment character?
And finally, why make this change at all? Kconfig files usually do not
have comments in them, right?
thanks,
greg k-h
next prev parent reply other threads:[~2016-10-04 4:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 15:28 [PATCH]board/Kconfig: Add a paragraph that describes the simbol Keila Novo
2016-10-04 4:23 ` Greg Kroah-Hartman [this message]
[not found] ` <CACrt6ML2ggFy-mC5TLYmQQur30iKN91eNSRq6eiN6+un+AYR9Q@mail.gmail.com>
2016-10-04 8:18 ` Fwd: " keila novo
2016-10-04 8:25 ` Greg Kroah-Hartman
2016-10-04 9:17 ` keila novo
-- strict thread matches above, loose matches on Subject: below --
2016-09-28 23:10 Keila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004042323.GB21357@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=laurana5@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.