From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: keila novo <laurana5@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: Fwd: Re: [PATCH]board/Kconfig: Add a paragraph that describes the simbol
Date: Tue, 4 Oct 2016 10:25:00 +0200 [thread overview]
Message-ID: <20161004082500.GA1525@kroah.com> (raw)
In-Reply-To: <CACrt6MKMzB6dsxYkGBF-OG54e3UGgeCcH2_iGRoyA93=f4dXOg@mail.gmail.com>
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Tue, Oct 04, 2016 at 10:18:47AM +0200, keila novo wrote:
> ---------- Mensaje reenviado ----------
> De: "keila novo" <laurana5@gmail.com>
> Fecha: 4 oct. 2016 7:41
> Asunto: Re: [PATCH]board/Kconfig: Add a paragraph that describes the simbol
> Para: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> Cc:
>
> I made that change because when a checked with chechpatch.pl, it took a warning
> that said: "please write a paragraph that describes the config symbol fully".
> So I tried to fix it adding a little paragraph on the top of the file.
The "paragraph" should be in the help section for that Kconfig option,
not as a comment in the file. If you run checkpatch.pl on the file
after you made this change, I think you will still have the same
warning, right?
But, to write a help entry for a Kconfig option, requires that you
understand what the driver and option does. Based on your paragraph, I
don't know if you do know what this code is here for. So perhaps you
might want to move on to a different type of warning fix?
In other words, don't make a change just because a warning shows up, but
because you understand what the warning means, and what the change you
are making does.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2016-10-04 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 15:28 [PATCH]board/Kconfig: Add a paragraph that describes the simbol Keila Novo
2016-10-04 4:23 ` Greg Kroah-Hartman
[not found] ` <CACrt6ML2ggFy-mC5TLYmQQur30iKN91eNSRq6eiN6+un+AYR9Q@mail.gmail.com>
2016-10-04 8:18 ` Fwd: " keila novo
2016-10-04 8:25 ` Greg Kroah-Hartman [this message]
2016-10-04 9:17 ` keila novo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004082500.GA1525@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=laurana5@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.