All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 1/2] staging: iio: cdc: ad7152: Add blank line after function to increase readability
@ 2016-10-04  7:22 Anchal Jain
  2016-10-09  7:53 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Anchal Jain @ 2016-10-04  7:22 UTC (permalink / raw)
  To: gregkh; +Cc: jic23, lars, outreachy-kernel

Add a blank line after the function to increase the readability of the code.

Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
	changes in v4-
		-modify patch title
 drivers/staging/iio/cdc/ad7152.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index 1962052..f9767e9 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct device *dev,
 	mutex_unlock(&indio_dev->mlock);
 	return len;
 }
+
 static ssize_t ad7152_start_offset_calib(struct device *dev,
 					 struct device_attribute *attr,
 					 const char *buf,
@@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct device *dev,
 	return ad7152_start_calib(dev, attr, buf, len,
 				  AD7152_CONF_MODE_OFFS_CAL);
 }
+
 static ssize_t ad7152_start_gain_calib(struct device *dev,
 				       struct device_attribute *attr,
 				       const char *buf,
@@ -317,6 +319,7 @@ out:
 	mutex_unlock(&indio_dev->mlock);
 	return ret;
 }
+
 static int ad7152_read_raw(struct iio_dev *indio_dev,
 			   struct iio_chan_spec const *chan,
 			   int *val, int *val2,
@@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[] = {
 		BIT(IIO_CHAN_INFO_SCALE),
 	}
 };
+
 /*
  * device probe and remove
  */
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4 1/2] staging: iio: cdc: ad7152: Add blank line after function to increase readability
  2016-10-04  7:22 [PATCH v4 1/2] staging: iio: cdc: ad7152: Add blank line after function to increase readability Anchal Jain
@ 2016-10-09  7:53 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2016-10-09  7:53 UTC (permalink / raw)
  To: Anchal Jain, gregkh; +Cc: lars, outreachy-kernel

On 04/10/16 08:22, Anchal Jain wrote:
> Add a blank line after the function to increase the readability of the code.
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
Hi Anchal,

I applied V3.  Good to clean up patches, but once they've gone in just
remember to get the little details right for the next one!

(this confused me when I tried to apply V4 today :) Too early on a Sunday
and no coffee yet.

Jonathan
> ---
> 	changes in v4-
> 		-modify patch title
>  drivers/staging/iio/cdc/ad7152.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index 1962052..f9767e9 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct device *dev,
>  	mutex_unlock(&indio_dev->mlock);
>  	return len;
>  }
> +
>  static ssize_t ad7152_start_offset_calib(struct device *dev,
>  					 struct device_attribute *attr,
>  					 const char *buf,
> @@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct device *dev,
>  	return ad7152_start_calib(dev, attr, buf, len,
>  				  AD7152_CONF_MODE_OFFS_CAL);
>  }
> +
>  static ssize_t ad7152_start_gain_calib(struct device *dev,
>  				       struct device_attribute *attr,
>  				       const char *buf,
> @@ -317,6 +319,7 @@ out:
>  	mutex_unlock(&indio_dev->mlock);
>  	return ret;
>  }
> +
>  static int ad7152_read_raw(struct iio_dev *indio_dev,
>  			   struct iio_chan_spec const *chan,
>  			   int *val, int *val2,
> @@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[] = {
>  		BIT(IIO_CHAN_INFO_SCALE),
>  	}
>  };
> +
>  /*
>   * device probe and remove
>   */
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-09  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04  7:22 [PATCH v4 1/2] staging: iio: cdc: ad7152: Add blank line after function to increase readability Anchal Jain
2016-10-09  7:53 ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.