From: Elise-Lennion <elise.lennion@gmail.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: [PATCH] staging: sm750fb: Add log level to printk().
Date: Tue, 4 Oct 2016 06:53:44 -0300 [thread overview]
Message-ID: <20161004095344.GA3903@lennorien.com> (raw)
Fix checkpatch warning:
WARNING: printk() should include KERN_ facility level
KERN_ facility levels ensure that unecessary messages, in different steps of driver implemention and testing, don't saturate the log file.
When log level is not explicited it defaults to DEFAULT_MESSAGE_LOGLEVEL (usually "4"=KERN_WARNING). A module startup message usually isn't a WARNING.
Signed-off-by: Elise-Lennion <elise.lennion@gmail.com>
---
drivers/staging/sm750fb/ddk750_help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..fc7e936 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
devId750 = devId;
revId750 = revId;
if (revId == 0xfe)
- printk("found sm750le\n");
+ printk(KERN_INFO "found sm750le\n");
}
--
2.7.4
next reply other threads:[~2016-10-04 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 9:53 Elise-Lennion [this message]
2016-10-04 10:15 ` [Outreachy kernel] [PATCH] staging: sm750fb: Add log level to printk() Julia Lawall
2016-10-04 23:19 ` Elise Lennion
2016-10-05 5:50 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004095344.GA3903@lennorien.com \
--to=elise.lennion@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.