* [PATCH] staging: sm750fb: Add log level to printk().
@ 2016-10-04 9:53 Elise-Lennion
2016-10-04 10:15 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Elise-Lennion @ 2016-10-04 9:53 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, outreachy-kernel
Fix checkpatch warning:
WARNING: printk() should include KERN_ facility level
KERN_ facility levels ensure that unecessary messages, in different steps of driver implemention and testing, don't saturate the log file.
When log level is not explicited it defaults to DEFAULT_MESSAGE_LOGLEVEL (usually "4"=KERN_WARNING). A module startup message usually isn't a WARNING.
Signed-off-by: Elise-Lennion <elise.lennion@gmail.com>
---
drivers/staging/sm750fb/ddk750_help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..fc7e936 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
devId750 = devId;
revId750 = revId;
if (revId == 0xfe)
- printk("found sm750le\n");
+ printk(KERN_INFO "found sm750le\n");
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: sm750fb: Add log level to printk().
2016-10-04 9:53 [PATCH] staging: sm750fb: Add log level to printk() Elise-Lennion
@ 2016-10-04 10:15 ` Julia Lawall
2016-10-04 23:19 ` Elise Lennion
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2016-10-04 10:15 UTC (permalink / raw)
To: Elise-Lennion; +Cc: sudipm.mukherjee, teddy.wang, gregkh, outreachy-kernel
On Tue, 4 Oct 2016, Elise-Lennion wrote:
> Fix checkpatch warning:
>
> WARNING: printk() should include KERN_ facility level
>
> KERN_ facility levels ensure that unecessary messages, in different steps of driver implemention and testing, don't saturate the log file.
>
> When log level is not explicited it defaults to DEFAULT_MESSAGE_LOGLEVEL (usually "4"=KERN_WARNING). A module startup message usually isn't a WARNING.
When you made this change, I think checkpatch would then suggest you do
something else?
> Signed-off-by: Elise-Lennion <elise.lennion@gmail.com>
Is this your complete name? I wonder because of the hyphen.
julia
> ---
> drivers/staging/sm750fb/ddk750_help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> index 9637dd3..fc7e936 100644
> --- a/drivers/staging/sm750fb/ddk750_help.c
> +++ b/drivers/staging/sm750fb/ddk750_help.c
> @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> devId750 = devId;
> revId750 = revId;
> if (revId == 0xfe)
> - printk("found sm750le\n");
> + printk(KERN_INFO "found sm750le\n");
> }
>
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161004095344.GA3903%40lennorien.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: sm750fb: Add log level to printk().
2016-10-04 10:15 ` [Outreachy kernel] " Julia Lawall
@ 2016-10-04 23:19 ` Elise Lennion
2016-10-05 5:50 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Elise Lennion @ 2016-10-04 23:19 UTC (permalink / raw)
To: Julia Lawall; +Cc: sudipm.mukherjee, teddy.wang, gregkh, outreachy-kernel
On Tue, Oct 04, 2016 at 12:15:44PM +0200, Julia Lawall wrote:
>
>
> On Tue, 4 Oct 2016, Elise-Lennion wrote:
>
> > Fix checkpatch warning:
> >
> > WARNING: printk() should include KERN_ facility level
> >
> > KERN_ facility levels ensure that unecessary messages, in different steps of driver implemention and testing, don't saturate the log file.
> >
> > When log level is not explicited it defaults to DEFAULT_MESSAGE_LOGLEVEL (usually "4"=KERN_WARNING). A module startup message usually isn't a WARNING.
>
> When you made this change, I think checkpatch would then suggest you do
> something else?
>
Yes, now I see it suggests to replace printk() with other options. Although I'm sure I executed checkpatch after making the changes and didn't see any new warnings.
> > Signed-off-by: Elise-Lennion <elise.lennion@gmail.com>
>
> Is this your complete name? I wonder because of the hyphen.
>
> julia
>
My complete name is Elise Lennion, without the hyphen. I'll fix this in future patches.
I sent a new patch to fix the mentioned issues. In this case should I create a completely new patch or send it as a [PATCH v2]? I chose the latter, even though its subject is different. Thank you.
Elise
v2: https://groups.google.com/forum/#!topic/outreachy-kernel/-YJbFK96SFI
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: sm750fb: Add log level to printk().
2016-10-04 23:19 ` Elise Lennion
@ 2016-10-05 5:50 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-10-05 5:50 UTC (permalink / raw)
To: Elise Lennion; +Cc: sudipm.mukherjee, teddy.wang, gregkh, outreachy-kernel
On Tue, 4 Oct 2016, Elise Lennion wrote:
> On Tue, Oct 04, 2016 at 12:15:44PM +0200, Julia Lawall wrote:
> >
> >
> > On Tue, 4 Oct 2016, Elise-Lennion wrote:
> >
> > > Fix checkpatch warning:
> > >
> > > WARNING: printk() should include KERN_ facility level
> > >
> > > KERN_ facility levels ensure that unecessary messages, in different steps of driver implemention and testing, don't saturate the log file.
> > >
> > > When log level is not explicited it defaults to DEFAULT_MESSAGE_LOGLEVEL (usually "4"=KERN_WARNING). A module startup message usually isn't a WARNING.
> >
> > When you made this change, I think checkpatch would then suggest you do
> > something else?
> >
>
> Yes, now I see it suggests to replace printk() with other options. Although I'm sure I executed checkpatch after making the changes and didn't see any new warnings.
>
> > > Signed-off-by: Elise-Lennion <elise.lennion@gmail.com>
> >
> > Is this your complete name? I wonder because of the hyphen.
> >
> > julia
> >
>
> My complete name is Elise Lennion, without the hyphen. I'll fix this in future patches.
>
> I sent a new patch to fix the mentioned issues. In this case should I create a completely new patch or send it as a [PATCH v2]? I chose the latter, even though its subject is different. Thank you.
v2 seems fine.
julia
>
> Elise
>
> v2: https://groups.google.com/forum/#!topic/outreachy-kernel/-YJbFK96SFI
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161004231931.GB5862%40lennorien.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-05 5:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04 9:53 [PATCH] staging: sm750fb: Add log level to printk() Elise-Lennion
2016-10-04 10:15 ` [Outreachy kernel] " Julia Lawall
2016-10-04 23:19 ` Elise Lennion
2016-10-05 5:50 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.