[PATCH v2 2/2] staging: android: ion: Use sizeof type *pointer instead of sizeof type.

[PATCH v2 2/2] staging: android: ion: Use sizeof type *pointer instead of sizeof type.

[Anchal Jain]

Use sizeof type *pointer instead of sizeof type.

Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
	changes in v2-
		-modify the commit message
		-modify the patch 
 drivers/staging/android/ion/ion.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index f8708c7..cd40ef7 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -184,7 +184,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
 	struct scatterlist *sg;
 	int i, ret;
 
-	buffer = kzalloc(sizeof(struct ion_buffer), GFP_KERNEL);
+	buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
 	if (!buffer)
 		return ERR_PTR(-ENOMEM);
 
@@ -341,7 +341,7 @@ static struct ion_handle *ion_handle_create(struct ion_client *client,
 {
 	struct ion_handle *handle;
 
-	handle = kzalloc(sizeof(struct ion_handle), GFP_KERNEL);
+	handle = kzalloc(sizeof(*handle), GFP_KERNEL);
 	if (!handle)
 		return ERR_PTR(-ENOMEM);
 	kref_init(&handle->ref);
@@ -802,7 +802,7 @@ struct ion_client *ion_client_create(struct ion_device *dev,
 	}
 	task_unlock(current->group_leader);
 
-	client = kzalloc(sizeof(struct ion_client), GFP_KERNEL);
+	client = kzalloc(sizeof(*client), GFP_KERNEL);
 	if (!client)
 		goto err_put_task_struct;
 
@@ -1010,7 +1010,7 @@ static void ion_vm_open(struct vm_area_struct *vma)
 	struct ion_buffer *buffer = vma->vm_private_data;
 	struct ion_vma_list *vma_list;
 
-	vma_list = kmalloc(sizeof(struct ion_vma_list), GFP_KERNEL);
+	vma_list = kmalloc(sizeof(*vma_list), GFP_KERNEL);
 	if (!vma_list)
 		return;
 	vma_list->vma = vma;
@@ -1621,7 +1621,7 @@ struct ion_device *ion_device_create(long (*custom_ioctl)
 	struct ion_device *idev;
 	int ret;
 
-	idev = kzalloc(sizeof(struct ion_device), GFP_KERNEL);
+	idev = kzalloc(sizeof(*idev), GFP_KERNEL);
 	if (!idev)
 		return ERR_PTR(-ENOMEM);
 
-- 
1.9.1

Re: [PATCH v2 2/2] staging: android: ion: Use sizeof type *pointer instead of sizeof type.

[Greg KH]

On Wed, Oct 05, 2016 at 11:34:32AM +0530, Anchal Jain wrote:
> Use sizeof type *pointer instead of sizeof type.
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> 	changes in v2-
> 		-modify the commit message
> 		-modify the patch 
>  drivers/staging/android/ion/ion.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Someone else already made this change before you did, sorry.

greg k-h