All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>,
	Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Mike Galbraith
	<umgwanakikbuti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	kernel-team-b10kYP2dOMg@public.gmane.org,
	"open list:CONTROL GROUP (CGROUP)"
	<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Paul Turner <pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Linus Torvalds
	<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [Documentation] State of CPU controller in cgroup v2
Date: Wed, 5 Oct 2016 10:07:55 +0200	[thread overview]
Message-ID: <20161005080755.GE3142@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20161004144717.GA4205-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>

On Tue, Oct 04, 2016 at 10:47:17AM -0400, Tejun Heo wrote:
> > cgroup-v2, by placing the system style controllers first and foremost,
> > completely renders that scenario impossible. Note also that any proposed
> > rgroup would not work for this, since that, per design, is a subtree,
> > and therefore not disjoint.
> 
> If a use case absolutely requires disjoint resource hierarchies, the
> only solution is to keep using multiple v1 hierarchies, which
> necessarily excludes the possibility of doing anyting across different
> resource types.
> 
> > So my objection to the whole cgroup-v2 model and implementation stems
> > from the fact that it purports to be a 'better' and 'improved' system,
> > while in actuality it neuters and destroys a lot of useful usecases.
> > 
> > It completely disregards all task-controllers and labels their use-cases
> > as irrelevant.
> 
> Your objection then doesn't have much to do with the specifics of the
> cgroup v2 model or implementation.

It is too, I've stated multiple times that the no internal tasks thing
is bad and that the root exception is an inexcusable wart that makes the
whole thing internally inconsistent.

But talking to you guys is pointless. You'll just keep moving air until
the other party tires and gives up.

My NAK on v2 stands.

> It's an objection against
> establishing common resource domains as that excludes building
> orthogonal multiple hierarchies.  That, necessarily, can only be
> achieved by having multiple hierarchies for different resource types
> and thus giving up the benefits of common resource domains.

Yes, v2 not allowing that rules it out as a valid model.

> Assuming that, I don't think your position is against cgroup v2 but
> more toward keeping v1 around.  We're talking about two quite
> different mutually exclusive classes of use cases.  You need unified
> for one and disjoint for the other.  v1 is gonna be there and can
> easily be used alongside v2 for different controller types, which
> would in most cases be cpu and cpuset.
> 
> I can't see a reason why this would need to block properly supporting
> containerization use cases.

I don't block that use-case, I block cgroup-v2, its shit.

The fact is, the naming "v2" suggests its a replacement and will
deprecate "v1". Also the implementation is mutually exclusive with v1,
you have to pick one and the other becomes inaccessible.

You cannot even pick another one inside a container, breaking the
container invariant.


WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Ingo Molnar <mingo@redhat.com>,
	Mike Galbraith <umgwanakikbuti@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel-team@fb.com,
	"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul Turner <pjt@google.com>, Li Zefan <lizefan@huawei.com>,
	Linux API <linux-api@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [Documentation] State of CPU controller in cgroup v2
Date: Wed, 5 Oct 2016 10:07:55 +0200	[thread overview]
Message-ID: <20161005080755.GE3142@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20161004144717.GA4205@htj.duckdns.org>

On Tue, Oct 04, 2016 at 10:47:17AM -0400, Tejun Heo wrote:
> > cgroup-v2, by placing the system style controllers first and foremost,
> > completely renders that scenario impossible. Note also that any proposed
> > rgroup would not work for this, since that, per design, is a subtree,
> > and therefore not disjoint.
> 
> If a use case absolutely requires disjoint resource hierarchies, the
> only solution is to keep using multiple v1 hierarchies, which
> necessarily excludes the possibility of doing anyting across different
> resource types.
> 
> > So my objection to the whole cgroup-v2 model and implementation stems
> > from the fact that it purports to be a 'better' and 'improved' system,
> > while in actuality it neuters and destroys a lot of useful usecases.
> > 
> > It completely disregards all task-controllers and labels their use-cases
> > as irrelevant.
> 
> Your objection then doesn't have much to do with the specifics of the
> cgroup v2 model or implementation.

It is too, I've stated multiple times that the no internal tasks thing
is bad and that the root exception is an inexcusable wart that makes the
whole thing internally inconsistent.

But talking to you guys is pointless. You'll just keep moving air until
the other party tires and gives up.

My NAK on v2 stands.

> It's an objection against
> establishing common resource domains as that excludes building
> orthogonal multiple hierarchies.  That, necessarily, can only be
> achieved by having multiple hierarchies for different resource types
> and thus giving up the benefits of common resource domains.

Yes, v2 not allowing that rules it out as a valid model.

> Assuming that, I don't think your position is against cgroup v2 but
> more toward keeping v1 around.  We're talking about two quite
> different mutually exclusive classes of use cases.  You need unified
> for one and disjoint for the other.  v1 is gonna be there and can
> easily be used alongside v2 for different controller types, which
> would in most cases be cpu and cpuset.
> 
> I can't see a reason why this would need to block properly supporting
> containerization use cases.

I don't block that use-case, I block cgroup-v2, its shit.

The fact is, the naming "v2" suggests its a replacement and will
deprecate "v1". Also the implementation is mutually exclusive with v1,
you have to pick one and the other becomes inaccessible.

You cannot even pick another one inside a container, breaking the
container invariant.

  parent reply	other threads:[~2016-10-05  8:07 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05 17:07 [Documentation] State of CPU controller in cgroup v2 Tejun Heo
2016-08-05 17:07 ` Tejun Heo
2016-08-05 17:09 ` [PATCH 1/2] sched: Misc preps for cgroup unified hierarchy interface Tejun Heo
2016-08-05 17:09   ` Tejun Heo
2016-08-05 17:09 ` [PATCH 2/2] sched: Implement interface for cgroup unified hierarchy Tejun Heo
2016-08-05 17:09   ` Tejun Heo
     [not found] ` <20160805170752.GK2542-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-08-06  9:04   ` [Documentation] State of CPU controller in cgroup v2 Mike Galbraith
2016-08-06  9:04     ` Mike Galbraith
     [not found]     ` <1470474291.4117.243.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-10 22:09       ` Johannes Weiner
2016-08-10 22:09         ` Johannes Weiner
     [not found]         ` <20160810220944.GB3085-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2016-08-11  6:25           ` Mike Galbraith
2016-08-11  6:25             ` Mike Galbraith
     [not found]             ` <1470896706.4116.146.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-12 22:17               ` Johannes Weiner
2016-08-12 22:17                 ` Johannes Weiner
     [not found]                 ` <20160812221742.GA24736-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2016-08-13  5:08                   ` Mike Galbraith
2016-08-13  5:08                     ` Mike Galbraith
2016-08-16 14:07           ` Peter Zijlstra
2016-08-16 14:07             ` Peter Zijlstra
     [not found]             ` <20160816140738.GW6879-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2016-08-16 14:58               ` Chris Mason
2016-08-16 14:58                 ` Chris Mason
2016-08-16 16:30               ` Johannes Weiner
2016-08-16 16:30                 ` Johannes Weiner
2016-08-17  9:33                 ` Mike Galbraith
2016-08-16 21:59               ` Tejun Heo
2016-08-16 21:59                 ` Tejun Heo
2016-08-17 20:18 ` Andy Lutomirski
     [not found]   ` <CALCETrXvLNeds+ugZ8j3eD1Zg1RZYJSAET3Kguz5G2vqSLFCwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-20 15:56     ` Tejun Heo
2016-08-20 15:56       ` Tejun Heo
2016-08-20 18:45       ` Andy Lutomirski
     [not found]         ` <CALCETrUWn1ux-ZRJoMjFCuP1aQrPOo3oTPD7k-ojsaov29NsRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-29 22:20           ` Tejun Heo
2016-08-29 22:20             ` Tejun Heo
     [not found]             ` <20160829222048.GH28713-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-08-31  3:42               ` Andy Lutomirski
2016-08-31  3:42                 ` Andy Lutomirski
2016-08-31 17:32                 ` Tejun Heo
     [not found]                   ` <20160831173251.GY12660-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-08-31 19:11                     ` Andy Lutomirski
2016-08-31 19:11                       ` Andy Lutomirski
     [not found]                       ` <CALCETrUKOJZS+=QDPyQD+vxXpwyjoj4+Crg6wU7Xk8rP4prYkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-31 21:07                         ` Tejun Heo
2016-08-31 21:07                           ` Tejun Heo
2016-08-31 21:46                           ` Andy Lutomirski
     [not found]                             ` <CALCETrXj2Z=-GMaWV_EpCvw_8C3t1vc=D53Ff2wdvo=At8ZF1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-03 22:05                               ` Tejun Heo
2016-09-03 22:05                                 ` Tejun Heo
2016-09-05 17:37                                 ` Andy Lutomirski
     [not found]                                   ` <CALCETrVcAjFWLQ1arjSP-g=4jRY_J7G-j9JJHrvTDgOnxApYPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-06 10:29                                     ` Peter Zijlstra
2016-09-06 10:29                                       ` Peter Zijlstra
2016-10-04 14:47                                       ` Tejun Heo
     [not found]                                         ` <20161004144717.GA4205-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-05  8:07                                           ` Peter Zijlstra [this message]
2016-10-05  8:07                                             ` Peter Zijlstra
2016-09-09 22:57                                   ` Tejun Heo
     [not found]                                     ` <20160909225747.GA30105-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-09-10  8:54                                       ` Mike Galbraith
2016-09-10  8:54                                         ` Mike Galbraith
2016-09-10 10:08                                       ` Mike Galbraith
2016-09-10 10:08                                         ` Mike Galbraith
     [not found]                                         ` <1473502137.3857.218.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-30  9:06                                           ` Tejun Heo
2016-09-30  9:06                                             ` Tejun Heo
     [not found]                                             ` <20160930090603.GD29207-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-09-30 14:53                                               ` Mike Galbraith
2016-09-30 14:53                                                 ` Mike Galbraith
2016-09-12 15:20                                       ` Austin S. Hemmelgarn
2016-09-12 15:20                                         ` Austin S. Hemmelgarn
     [not found]                                         ` <ab6f3376-4c09-a339-f984-937f537ddc17-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-19 21:34                                           ` Tejun Heo
2016-09-19 21:34                                             ` Tejun Heo
     [not found]                                     ` <CALCETrUhpPQdyZ-6WRjdB+iLbpGBduRZMWXQtCuS+R7Cq7rygg@mail.gmail.com>
2016-09-14 20:00                                       ` Tejun Heo
     [not found]                                         ` <20160914200041.GB6832-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-09-15 20:08                                           ` Andy Lutomirski
2016-09-15 20:08                                             ` Andy Lutomirski
     [not found]                                             ` <CALCETrUA6_noue4kq9JLqr-V_yo7hB+v1Arhg6i6fFn0tyTrpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-16  7:51                                               ` Peter Zijlstra
2016-09-16  7:51                                                 ` Peter Zijlstra
     [not found]                                                 ` <20160916075137.GK5012-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2016-09-16 15:12                                                   ` Andy Lutomirski
2016-09-16 15:12                                                     ` Andy Lutomirski
     [not found]                                                     ` <CALCETrXzrXJmZoFVfAXS1Zf9uNZjibnHizEhwgqdmRvnbJEksw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-16 16:19                                                       ` Peter Zijlstra
2016-09-16 16:19                                                         ` Peter Zijlstra
     [not found]                                                         ` <20160916161951.GH5016-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2016-09-16 16:29                                                           ` Andy Lutomirski
2016-09-16 16:29                                                             ` Andy Lutomirski
     [not found]                                                             ` <CALCETrXoTfhaDxZJ9_XcFknnniDvrYLY9SATVXj+tK1UdaWw4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-16 16:50                                                               ` Peter Zijlstra
2016-09-16 16:50                                                                 ` Peter Zijlstra
     [not found]                                                                 ` <20160916165045.GJ5016-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2016-09-16 18:19                                                                   ` Andy Lutomirski
2016-09-16 18:19                                                                     ` Andy Lutomirski
     [not found]                                                                     ` <CALCETrVMw4Nd-QZER9qzOzRte5s48WrUaM8ZZzkY_g3B6s+5Ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-17  1:47                                                                       ` Peter Zijlstra
2016-09-17  1:47                                                                         ` Peter Zijlstra
2016-09-19 21:53                                               ` Tejun Heo
2016-09-19 21:53                                                 ` Tejun Heo
2016-08-31 19:57               ` Andy Lutomirski
2016-08-31 19:57                 ` Andy Lutomirski
     [not found]       ` <20160820155659.GA16906-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-08-22 10:12         ` Mike Galbraith
2016-08-22 10:12           ` Mike Galbraith
2016-08-21  5:34     ` James Bottomley
2016-08-21  5:34       ` James Bottomley
     [not found]       ` <1471757654.2354.97.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2016-08-29 22:35         ` Tejun Heo
2016-08-29 22:35           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161005080755.GE3142@twins.programming.kicks-ass.net \
    --to=peterz-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kernel-team-b10kYP2dOMg@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=umgwanakikbuti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.