From: Eduardo Habkost <ehabkost@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
qemu-devel@nongnu.org,
"Alistair Francis" <alistair.francis@xilinx.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Alexander Graf" <agraf@suse.de>,
qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-arm] [PATCH 2/2] coccinelle: use object_new_with_class() in obvious cases
Date: Wed, 5 Oct 2016 11:44:51 -0300 [thread overview]
Message-ID: <20161005144451.GL3877@thinpad.lan.raisama.net> (raw)
In-Reply-To: <20161005133530.5702-3-rkrcmar@redhat.com>
On Wed, Oct 05, 2016 at 03:35:30PM +0200, Radim Krčmář wrote:
> object_new_with_class(class) does a better job than
> object_new(object_class_get_name(class)), because
> object_class_get_name() lost the class->type and object_new() looked it
> up again from the name.
>
> Manually changed vl.c to fit into 80 character line.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: qemu-devel@nongnu.org, "Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alistair Francis" <alistair.francis@xilinx.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Max Filippov" <jcmvbkbc@gmail.com>,
qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] coccinelle: use object_new_with_class() in obvious cases
Date: Wed, 5 Oct 2016 11:44:51 -0300 [thread overview]
Message-ID: <20161005144451.GL3877@thinpad.lan.raisama.net> (raw)
In-Reply-To: <20161005133530.5702-3-rkrcmar@redhat.com>
On Wed, Oct 05, 2016 at 03:35:30PM +0200, Radim Krčmář wrote:
> object_new_with_class(class) does a better job than
> object_new(object_class_get_name(class)), because
> object_class_get_name() lost the class->type and object_new() looked it
> up again from the name.
>
> Manually changed vl.c to fit into 80 character line.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2016-10-05 14:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 13:35 [Qemu-devel] [PATCH 0/2] qom+coccinelle: add and use object_new_with_class() Radim Krčmář
2016-10-05 13:35 ` Radim Krčmář
2016-10-05 13:35 ` [Qemu-devel] [PATCH 1/2] qom: add object_new_with_class() Radim Krčmář
2016-10-05 13:35 ` Radim Krčmář
2016-10-05 14:44 ` [Qemu-arm] " Eduardo Habkost
2016-10-05 14:44 ` [Qemu-devel] " Eduardo Habkost
2016-10-05 15:54 ` [Qemu-arm] " Alistair Francis
2016-10-05 15:54 ` Alistair Francis
2016-10-05 13:35 ` [Qemu-devel] [PATCH 2/2] coccinelle: use object_new_with_class() in obvious cases Radim Krčmář
2016-10-05 13:35 ` Radim Krčmář
2016-10-05 14:44 ` Eduardo Habkost [this message]
2016-10-05 14:44 ` Eduardo Habkost
2016-10-05 15:56 ` [Qemu-arm] " Alistair Francis
2016-10-05 15:56 ` Alistair Francis
2016-10-05 13:42 ` [Qemu-devel] [PATCH 0/2] qom+coccinelle: add and use object_new_with_class() Radim Krčmář
2016-10-05 13:42 ` Radim Krčmář
2016-11-03 16:54 ` [Qemu-arm] " Markus Armbruster
2016-11-03 16:54 ` Markus Armbruster
2016-11-03 19:16 ` [Qemu-arm] " Eduardo Habkost
2016-11-03 19:16 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005144451.GL3877@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=i.mitsyanko@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.