From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, vsementsov@virtuozzo.com, famz@redhat.com,
stefanha@redhat.com, jcody@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 09/11] blockjob: add block_job_start
Date: Wed, 5 Oct 2016 17:17:06 +0200 [thread overview]
Message-ID: <20161005151706.GG1657@noname.str.redhat.com> (raw)
In-Reply-To: <1475272849-19990-10-git-send-email-jsnow@redhat.com>
Am 01.10.2016 um 00:00 hat John Snow geschrieben:
> Instead of automatically starting jobs at creation time via backup_start
> et al, we'd like to return a job object pointer that can be started
> manually at later point in time.
>
> For now, add the block_job_start mechanism and start the jobs
> automatically as we have been doing, with conversions job-by-job coming
> in later patches.
>
> Of note: cancellation of unstarted jobs will perform all the normal
> cleanup as if the job had started, particularly abort and clean. The
> only difference is that we will not emit any events, because the job
> never actually started.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Should we make sure that jobs are only added to the block_jobs list once
they are started? It doesn't sound like a good idea to make a job
without a coroutine user-accessible.
Kevin
next prev parent reply other threads:[~2016-10-05 15:17 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 22:00 [Qemu-devel] [PATCH v2 00/11] blockjobs: Fix transactional race condition John Snow
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 01/11] blockjob: fix dead pointer in txn list John Snow
2016-10-05 13:43 ` Kevin Wolf
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 02/11] blockjob: centralize QMP event emissions John Snow
2016-10-05 13:43 ` Kevin Wolf
2016-10-05 18:49 ` John Snow
2016-10-05 19:24 ` Eric Blake
2016-10-05 21:00 ` John Snow
2016-10-10 16:45 ` Kashyap Chamarthy
2016-10-10 18:36 ` John Snow
2016-10-10 19:28 ` Eric Blake
2016-10-11 13:32 ` Kashyap Chamarthy
2016-10-06 7:44 ` Kevin Wolf
2016-10-06 16:57 ` John Snow
2016-10-06 18:16 ` Eric Blake
2016-10-06 18:19 ` John Snow
2016-10-11 9:50 ` Markus Armbruster
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 03/11] Blockjobs: Internalize user_pause logic John Snow
2016-10-04 0:57 ` Jeff Cody
2016-10-04 2:46 ` John Snow
2016-10-04 18:35 ` John Snow
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context John Snow
2016-10-05 14:02 ` Kevin Wolf
2016-10-06 20:22 ` John Snow
2016-10-07 7:49 ` Paolo Bonzini
2016-10-13 0:49 ` John Snow
2016-10-13 9:03 ` Paolo Bonzini
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 05/11] blockjobs: split interface into public/private John Snow
2016-10-05 14:17 ` Kevin Wolf
2016-10-05 16:20 ` John Snow
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 06/11] blockjobs: fix documentation John Snow
2016-10-05 15:03 ` Kevin Wolf
2016-10-05 16:22 ` John Snow
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 07/11] blockjob: add .clean property John Snow
2016-10-12 11:11 ` Vladimir Sementsov-Ogievskiy
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 08/11] blockjob: add .start field John Snow
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 09/11] blockjob: add block_job_start John Snow
2016-10-05 15:17 ` Kevin Wolf [this message]
2016-10-06 22:44 ` John Snow
2016-10-17 18:00 ` John Snow
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 10/11] blockjob: refactor backup_start as backup_job_create John Snow
2016-10-07 18:39 ` John Snow
2016-10-10 8:57 ` Kevin Wolf
2016-10-10 22:51 ` John Snow
2016-10-11 8:56 ` Paolo Bonzini
2016-10-11 9:35 ` Kevin Wolf
2016-10-17 8:59 ` Fam Zheng
2016-09-30 22:00 ` [Qemu-devel] [PATCH v2 11/11] iotests: add transactional failure race test John Snow
2016-10-12 11:26 ` Vladimir Sementsov-Ogievskiy
2016-10-12 16:09 ` John Snow
2016-09-30 22:22 ` [Qemu-devel] [PATCH v2 00/11] blockjobs: Fix transactional race condition no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005151706.GG1657@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.