All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nadim Almas <nadim.902@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
	devel@driverdev.osuosl.org,
	driverdev-devel@linuxdriverproject.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue
Date: Thu, 6 Oct 2016 07:21:48 +0200	[thread overview]
Message-ID: <20161006052148.GA20295@kroah.com> (raw)
In-Reply-To: <20161005215358.GA4231@gmail.com>

On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote:
> Fixed coding style issue
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
> index abddd48..65994e3 100644
> --- a/drivers/staging/dgnc/dgnc_neo.h
> +++ b/drivers/staging/dgnc/dgnc_neo.h
> @@ -30,7 +30,8 @@
>  struct neo_uart_struct {
>  	u8 txrx;		/* WR  RHR/THR - Holding Reg */
>  	u8 ier;		/* WR  IER - Interrupt Enable Reg */
> -	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> +	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
> +									/*Reg */

Does that really look better now than it did before?

I don't think so :(

sorry,

greg k-h

  reply	other threads:[~2016-10-06  5:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05 21:53 [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue Nadim Almas
2016-10-06  5:21 ` Greg KH [this message]
2016-10-06  8:22   ` Nadim Almas
2016-10-06 15:23     ` Nadim Almas
2016-10-06 15:52       ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2016-09-30 21:49 Nadim Almas
2016-10-02 15:23 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161006052148.GA20295@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=nadim.902@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.