All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nadim Almas <nadim.902@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue
Date: Sun, 2 Oct 2016 17:23:55 +0200	[thread overview]
Message-ID: <20161002152355.GB32091@kroah.com> (raw)
In-Reply-To: <20160930214912.GA6932@gmail.com>

On Fri, Sep 30, 2016 at 02:49:12PM -0700, Nadim Almas wrote:
> Fixed coding style issue.
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index e794056..bc15584 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
>  		 * Rx Oruns. Exar says that an orun will NOT corrupt
>  		 * the FIFO. It will just replace the holding register
>  		 * with this new data byte. So basically just ignore this.
> -		 * Probably we should eventually have an orun stat in our driver...
> +		 * Probably we should eventually have an orun stat in our
> +		 * driver...
>  		 */
>  		ch->ch_err_overrun++;
>  	}

Why did you just fix only one of these warnings in the file?  You aren't
going to send one patch per instance of this warning in this file, are
you?  Please group it all into one.

thanks,

greg k-h

  reply	other threads:[~2016-10-02 15:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30 21:49 [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue Nadim Almas
2016-10-02 15:23 ` Greg KH [this message]
     [not found]   ` <CANQNnfGy50kygxezO3WEt+zHh5EH5RRgvKkJA0OFU7BFPMn5KQ@mail.gmail.com>
     [not found]     ` <20161002153937.GA21118@kroah.com>
2016-10-02 15:43       ` Fwd: " Nadim Almas
2016-10-02 16:09         ` Greg KH
2016-10-02 16:41           ` Nadim Almas
2016-10-02 17:49             ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2016-10-05 21:53 Nadim Almas
2016-10-06  5:21 ` Greg KH
2016-10-06  8:22   ` Nadim Almas
2016-10-06 15:23     ` Nadim Almas
2016-10-06 15:52       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161002152355.GB32091@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadim.902@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.