All of lore.kernel.org
 help / color / mirror / Atom feed
From: l.majewski@majess.pl (Lukasz Majewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] arm: dts: imx7-colibri: Use pwm polarity control
Date: Thu, 6 Oct 2016 08:40:07 +0200	[thread overview]
Message-ID: <20161006084007.44c5cbae@jawa> (raw)
In-Reply-To: <20161001101235.24598-6-bhuvanchandra.dv@toradex.com>

On Sat, 1 Oct 2016 15:42:34 +0530
Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> wrote:

> Configure PWM polarity control.
> 
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
>  arch/arm/boot/dts/imx7-colibri.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> b/arch/arm/boot/dts/imx7-colibri.dtsi index a9cc657..2af5e3e 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -43,7 +43,7 @@
>  / {
>  	bl: backlight {
>  		compatible = "pwm-backlight";
> -		pwms = <&pwm1 0 5000000>;
> +		pwms = <&pwm1 0 5000000 0>;

My recommendation would be to add:
#include <dt-bindings/pwm/pwm.h>

and then define pwms as:

pwms = <&pwm1 0 5000000 PWM_POLARITY_NORMAL>;

It would be more readable

Best regards,
?ukasz Majewski

>  	};
>  
>  	reg_module_3v3: regulator-module-3v3 {

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161006/124c447f/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Majewski <l.majewski@majess.pl>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: devicetree@vger.kernel.org, stefan@agner.ch,
	thierry.reding@gmail.com, kernel@pengutronix.de,
	fabio.estevam@nxp.com, shawnguo@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/6] arm: dts: imx7-colibri: Use pwm polarity control
Date: Thu, 6 Oct 2016 08:40:07 +0200	[thread overview]
Message-ID: <20161006084007.44c5cbae@jawa> (raw)
In-Reply-To: <20161001101235.24598-6-bhuvanchandra.dv@toradex.com>


[-- Attachment #1.1: Type: text/plain, Size: 945 bytes --]

On Sat, 1 Oct 2016 15:42:34 +0530
Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> wrote:

> Configure PWM polarity control.
> 
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
>  arch/arm/boot/dts/imx7-colibri.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> b/arch/arm/boot/dts/imx7-colibri.dtsi index a9cc657..2af5e3e 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -43,7 +43,7 @@
>  / {
>  	bl: backlight {
>  		compatible = "pwm-backlight";
> -		pwms = <&pwm1 0 5000000>;
> +		pwms = <&pwm1 0 5000000 0>;

My recommendation would be to add:
#include <dt-bindings/pwm/pwm.h>

and then define pwms as:

pwms = <&pwm1 0 5000000 PWM_POLARITY_NORMAL>;

It would be more readable

Best regards,
Łukasz Majewski

>  	};
>  
>  	reg_module_3v3: regulator-module-3v3 {


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2016-10-06  6:40 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-01 10:12 [PATCH v2 0/6] Support PWM polarity control Bhuvanchandra DV
2016-10-01 10:12 ` Bhuvanchandra DV
2016-10-01 10:12 ` Bhuvanchandra DV
2016-10-01 10:12 ` [PATCH v2 1/6] pwm: print error messages with pr_err() instead of pr_debug() Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12 ` [PATCH v2 2/6] pwm: core: make the PWM_POLARITY flag in DTB optional Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-06  6:36   ` Lukasz Majewski
2016-10-06  6:36     ` Lukasz Majewski
2016-10-06  6:36     ` Lukasz Majewski
2016-10-07  4:49     ` Bhuvanchandra DV
2016-10-07  4:49       ` Bhuvanchandra DV
2016-10-07  4:49       ` Bhuvanchandra DV
2016-10-06  6:49   ` [PATCH] pwm: core: Use pwm->args.polarity to setup PWM_POLARITY_INVERSED Lukasz Majewski
2016-10-06  6:49     ` Lukasz Majewski
2016-10-06  6:49     ` Lukasz Majewski
2016-10-01 10:12 ` [PATCH v2 3/6] pwm: imx: support output polarity inversion Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12 ` [PATCH v2 4/6] arm: dts: imx7: Update #pwm-cells for PWM polarity control Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12 ` [PATCH v2 5/6] arm: dts: imx7-colibri: Use pwm " Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-06  6:40   ` Lukasz Majewski [this message]
2016-10-06  6:40     ` Lukasz Majewski
2016-10-07  4:49     ` Bhuvanchandra DV
2016-10-07  4:49       ` Bhuvanchandra DV
2016-10-07  6:08     ` Bhuvanchandra DV
2016-10-07  6:08       ` Bhuvanchandra DV
2016-10-07  6:41       ` Lukasz Majewski
2016-10-07  6:41         ` Lukasz Majewski
2016-10-01 10:12 ` [PATCH v2 6/6] arm: dts: imx7-colibri: Use enable-gpios for BL_ON Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-01 10:12   ` Bhuvanchandra DV
2016-10-04  7:48 ` [PATCH v2 0/6] Support PWM polarity control Lukasz Majewski
2016-10-04  7:48   ` Lukasz Majewski
2016-10-04  7:48   ` Lukasz Majewski
2016-10-05 16:50   ` Stefan Agner
2016-10-05 16:50     ` Stefan Agner
2016-10-05 16:50     ` Stefan Agner
2016-10-06  6:26     ` Lukasz Majewski
2016-10-06  6:26       ` Lukasz Majewski
2016-10-06  6:26       ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161006084007.44c5cbae@jawa \
    --to=l.majewski@majess.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.