* Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface" [not found] <20160930101318.GA24973@aditya-ubuntu.local> @ 2016-09-30 13:22 ` Greg KH 2016-10-06 9:56 ` Aditya Shankar 0 siblings, 1 reply; 3+ messages in thread From: Greg KH @ 2016-09-30 13:22 UTC (permalink / raw) To: Aditya Shankar Cc: ganesh.krishna, linux-wireless, devel, linux-kernel, Nicolas.Ferre On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote: > This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread > with workqueue for host interface") > > This commit breaks wilc1000 driver init. A crash was seen > everytime the wlan interface was brought up and wilc device > open was attempted. This change is being reverted until we > figure out the problem in this change. The driver is > usable now with this change reverted. > > Signed-off-by: Aditya Shankar <Aditya.Shankar@microchip.com> > > Conflicts: > drivers/staging/wilc1000/host_interface.c What is this line doing here? And shouldn't we add a cc: stable tag as well? Or at the least, put a "fixes:" tag to let people know exactly what commit it is fixing (the id that it is reverting.) thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface" 2016-09-30 13:22 ` [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface" Greg KH @ 2016-10-06 9:56 ` Aditya Shankar 2016-10-06 10:17 ` Greg KH 0 siblings, 1 reply; 3+ messages in thread From: Aditya Shankar @ 2016-10-06 9:56 UTC (permalink / raw) To: Greg KH Cc: Aditya Shankar, ganesh.krishna, linux-wireless, devel, linux-kernel, Nicolas.Ferre On Fri, 30 Sep 2016 15:22:15 +0200 Greg KH <gregkh@linuxfoundation.org> wrote: > On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote: > > This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread > > with workqueue for host interface") > > > > This commit breaks wilc1000 driver init. A crash was seen > > everytime the wlan interface was brought up and wilc device > > open was attempted. This change is being reverted until we > > figure out the problem in this change. The driver is > > usable now with this change reverted. > > > > Signed-off-by: Aditya Shankar <Aditya.Shankar@microchip.com> > > > > Conflicts: > > drivers/staging/wilc1000/host_interface.c > > What is this line doing here? > > And shouldn't we add a cc: stable tag as well? Or at the least, put a > "fixes:" tag to let people know exactly what commit it is fixing (the > id that it is reverting.) > > thanks, > > greg k-h Apologies for this bad commit message. I have an update on this wilc1000 crash issue. I've figured out the cause for the crash and fixed it. Therefore, I request you to ignore the patch I sent out to revert the change causing the regression. The cause was a misplaced call to destroy workqueue soon after creating it. With this removed, the issue is not seen. I will send out a separate patch to fix the issue. Thanks, Aditya ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface" 2016-10-06 9:56 ` Aditya Shankar @ 2016-10-06 10:17 ` Greg KH 0 siblings, 0 replies; 3+ messages in thread From: Greg KH @ 2016-10-06 10:17 UTC (permalink / raw) To: Aditya Shankar Cc: ganesh.krishna, linux-wireless, devel, linux-kernel, Nicolas.Ferre On Thu, Oct 06, 2016 at 03:26:59PM +0530, Aditya Shankar wrote: > On Fri, 30 Sep 2016 15:22:15 +0200 > Greg KH <gregkh@linuxfoundation.org> wrote: > > > On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote: > > > This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread > > > with workqueue for host interface") > > > > > > This commit breaks wilc1000 driver init. A crash was seen > > > everytime the wlan interface was brought up and wilc device > > > open was attempted. This change is being reverted until we > > > figure out the problem in this change. The driver is > > > usable now with this change reverted. > > > > > > Signed-off-by: Aditya Shankar <Aditya.Shankar@microchip.com> > > > > > > Conflicts: > > > drivers/staging/wilc1000/host_interface.c > > > > What is this line doing here? > > > > And shouldn't we add a cc: stable tag as well? Or at the least, put a > > "fixes:" tag to let people know exactly what commit it is fixing (the > > id that it is reverting.) > > > > thanks, > > > > greg k-h > > Apologies for this bad commit message. > > I have an update on this wilc1000 crash issue. I've figured out > the cause for the crash and fixed it. Therefore, > I request you to ignore the patch I sent out to > revert the change causing the regression. The cause was a misplaced > call to destroy workqueue soon after creating it. > With this removed, the issue is not seen. > > I will send out a separate patch to fix the issue. Wonderful, thanks for doing that, I'll drop these and use your fix when you send it. greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-06 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160930101318.GA24973@aditya-ubuntu.local>
2016-09-30 13:22 ` [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface" Greg KH
2016-10-06 9:56 ` Aditya Shankar
2016-10-06 10:17 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.