From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: don't destroy chip device prematurely
Date: Thu, 6 Oct 2016 14:23:57 +0300 [thread overview]
Message-ID: <20161006112357.GA10533@intel.com> (raw)
In-Reply-To: <20161005162741.GA18636@obsidianresearch.com>
On Wed, Oct 05, 2016 at 10:27:41AM -0600, Jason Gunthorpe wrote:
> On Wed, Oct 05, 2016 at 01:02:34PM +0300, Jarkko Sakkinen wrote:
>
> > I'll repeat my question: what worse can happen than returning -EPIPE? I
> > though the whole rw lock scheme was introduced just for this purpose.
>
> I thought I explained this, if device_del is moved after ops = null
> then if sysfs looses the race it will oops the kernel. device_del hard
> fences sysfs.
Sorry, I missed that comment somehow. Looking at the code it is like
that.
I think that they should be fenced then for the sake of consistency.
I do not see why sysfs code is privileged not to do fencing while other
peers have to do it.
/Jarkko
next prev parent reply other threads:[~2016-10-06 11:23 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 7:39 [PATCH] tpm: don't destroy chip device prematurely Tomas Winkler
[not found] ` <1475393971-12715-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-02 10:17 ` Jarkko Sakkinen
2016-10-02 10:17 ` Jarkko Sakkinen
[not found] ` <20161002101755.GA25844-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-02 10:24 ` Jarkko Sakkinen
2016-10-02 10:24 ` Jarkko Sakkinen
[not found] ` <20161002102455.GA27464-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-02 21:21 ` Jason Gunthorpe
2016-10-02 21:21 ` Jason Gunthorpe
[not found] ` <20161002212126.GA25872-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-03 7:05 ` Winkler, Tomas
2016-10-03 7:05 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F466B-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-03 7:38 ` Winkler, Tomas
2016-10-03 7:38 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F46C1-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-03 12:42 ` Jarkko Sakkinen
2016-10-03 12:42 ` Jarkko Sakkinen
2016-10-03 16:03 ` Jason Gunthorpe
[not found] ` <20161003160308.GA6801-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-03 17:30 ` Winkler, Tomas
2016-10-03 17:30 ` Winkler, Tomas
2016-10-03 12:48 ` Jarkko Sakkinen
[not found] ` <20161003124836.GE9990-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-04 5:19 ` Jarkko Sakkinen
2016-10-04 5:19 ` Jarkko Sakkinen
2016-10-04 16:47 ` Jason Gunthorpe
2016-10-04 21:55 ` Winkler, Tomas
2016-10-04 23:10 ` Jason Gunthorpe
[not found] ` <20161004231057.GA20062-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-05 7:48 ` Winkler, Tomas
2016-10-05 7:48 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F5084-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-05 15:15 ` Jarkko Sakkinen
2016-10-05 15:15 ` Jarkko Sakkinen
2016-10-05 16:37 ` Jason Gunthorpe
2016-10-05 17:11 ` Jason Gunthorpe
2016-10-05 20:09 ` Winkler, Tomas
2016-10-05 21:16 ` Jason Gunthorpe
2016-10-06 0:43 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F561B-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-06 2:07 ` Jason Gunthorpe
2016-10-06 2:07 ` Jason Gunthorpe
[not found] ` <20161006020748.GA17479-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-07 14:24 ` Winkler, Tomas
2016-10-07 14:24 ` Winkler, Tomas
2016-10-07 19:17 ` Jason Gunthorpe
[not found] ` <20161007191724.GA28795-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-07 20:10 ` Winkler, Tomas
2016-10-07 20:10 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F625A-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-08 10:47 ` Jarkko Sakkinen
2016-10-08 10:47 ` Jarkko Sakkinen
2016-10-05 10:02 ` Jarkko Sakkinen
[not found] ` <20161005100234.GA20851-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-05 16:27 ` Jason Gunthorpe
2016-10-05 16:27 ` Jason Gunthorpe
2016-10-06 11:23 ` Jarkko Sakkinen [this message]
2016-10-06 16:22 ` Jason Gunthorpe
[not found] ` <20161006162245.GF1224-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-06 16:46 ` Jarkko Sakkinen
2016-10-06 16:46 ` Jarkko Sakkinen
2016-10-05 10:09 ` Jarkko Sakkinen
2016-10-03 16:00 ` Jason Gunthorpe
2016-10-03 17:16 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F474C-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-03 17:30 ` Jason Gunthorpe
2016-10-03 17:30 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006112357.GA10533@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.