* Bogus "APIC: NR_CPUS/possible_cpus limit of 4 reached" messages @ 2016-10-06 11:27 Markus Trippelsdorf 2016-10-06 11:48 ` One Thousand Gnomes 0 siblings, 1 reply; 7+ messages in thread From: Markus Trippelsdorf @ 2016-10-06 11:27 UTC (permalink / raw) To: Gu Zheng; +Cc: linux-acpi, linux-kernel On current trunk I get during boot: [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 4/0x84 ignored. [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 5/0x85 ignored. I don't think these messages make much sense on a 4-core machine. -- Markus ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Bogus "APIC: NR_CPUS/possible_cpus limit of 4 reached" messages 2016-10-06 11:27 Bogus "APIC: NR_CPUS/possible_cpus limit of 4 reached" messages Markus Trippelsdorf @ 2016-10-06 11:48 ` One Thousand Gnomes 2016-10-06 11:52 ` Markus Trippelsdorf 0 siblings, 1 reply; 7+ messages in thread From: One Thousand Gnomes @ 2016-10-06 11:48 UTC (permalink / raw) To: Markus Trippelsdorf; +Cc: Gu Zheng, linux-acpi, linux-kernel On Thu, 6 Oct 2016 13:27:37 +0200 Markus Trippelsdorf <markus@trippelsdorf.de> wrote: > On current trunk I get during boot: > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 4/0x84 ignored. > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 5/0x85 ignored. > > I don't think these messages make much sense on a 4-core machine. > Four cores with or without hyperthreading ? Alan ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Bogus "APIC: NR_CPUS/possible_cpus limit of 4 reached" messages 2016-10-06 11:48 ` One Thousand Gnomes @ 2016-10-06 11:52 ` Markus Trippelsdorf 2016-10-07 13:26 ` Markus Trippelsdorf 0 siblings, 1 reply; 7+ messages in thread From: Markus Trippelsdorf @ 2016-10-06 11:52 UTC (permalink / raw) To: One Thousand Gnomes; +Cc: Gu Zheng, linux-acpi, linux-kernel On 2016.10.06 at 12:48 +0100, One Thousand Gnomes wrote: > On Thu, 6 Oct 2016 13:27:37 +0200 > Markus Trippelsdorf <markus@trippelsdorf.de> wrote: > > > On current trunk I get during boot: > > > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 4/0x84 ignored. > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 5/0x85 ignored. > > > > I don't think these messages make much sense on a 4-core machine. > > > > Four cores with or without hyperthreading ? Without. This is a rather old AMD machine (AMD Phenom II X4 955). -- Markus ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Bogus "APIC: NR_CPUS/possible_cpus limit of 4 reached" messages 2016-10-06 11:52 ` Markus Trippelsdorf @ 2016-10-07 13:26 ` Markus Trippelsdorf 2016-10-07 13:55 ` Thomas Gleixner 0 siblings, 1 reply; 7+ messages in thread From: Markus Trippelsdorf @ 2016-10-07 13:26 UTC (permalink / raw) To: One Thousand Gnomes Cc: Gu Zheng, linux-acpi, linux-kernel, Dou Liyang, Thomas Gleixner On 2016.10.06 at 13:52 +0200, Markus Trippelsdorf wrote: > On 2016.10.06 at 12:48 +0100, One Thousand Gnomes wrote: > > On Thu, 6 Oct 2016 13:27:37 +0200 > > Markus Trippelsdorf <markus@trippelsdorf.de> wrote: > > > > > On current trunk I get during boot: > > > > > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 4/0x84 ignored. > > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 5/0x85 ignored. > > > > > > I don't think these messages make much sense on a 4-core machine. > > > > > > > Four cores with or without hyperthreading ? > > Without. This is a rather old AMD machine (AMD Phenom II X4 955). CCing more people. -- Markus ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Bogus "APIC: NR_CPUS/possible_cpus limit of 4 reached" messages 2016-10-07 13:26 ` Markus Trippelsdorf @ 2016-10-07 13:55 ` Thomas Gleixner 2016-10-07 14:09 ` Markus Trippelsdorf 2016-10-08 10:24 ` [tip:x86/urgent] x86/apic: Prevent pointless warning messages tip-bot for Thomas Gleixner 0 siblings, 2 replies; 7+ messages in thread From: Thomas Gleixner @ 2016-10-07 13:55 UTC (permalink / raw) To: Markus Trippelsdorf Cc: One Thousand Gnomes, Gu Zheng, linux-acpi, linux-kernel, Dou Liyang On Fri, 7 Oct 2016, Markus Trippelsdorf wrote: > On 2016.10.06 at 13:52 +0200, Markus Trippelsdorf wrote: > > On 2016.10.06 at 12:48 +0100, One Thousand Gnomes wrote: > > > On Thu, 6 Oct 2016 13:27:37 +0200 > > > Markus Trippelsdorf <markus@trippelsdorf.de> wrote: > > > > > > > On current trunk I get during boot: > > > > > > > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 4/0x84 ignored. > > > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 5/0x85 ignored. > > > > > > > > I don't think these messages make much sense on a 4-core machine. > > > > > > > > > > Four cores with or without hyperthreading ? > > > > Without. This is a rather old AMD machine (AMD Phenom II X4 955). That's due to the recent cpuid -> nodeid changes. The patch below should fix it. Thanks, tglx diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index f266b8a92a9e..88c657b057e2 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2128,9 +2128,11 @@ int __generic_processor_info(int apicid, int version, bool enabled) if (num_processors >= nr_cpu_ids) { int thiscpu = max + disabled_cpus; - pr_warning( - "APIC: NR_CPUS/possible_cpus limit of %i reached." - " Processor %d/0x%x ignored.\n", max, thiscpu, apicid); + if (enabled) { + pr_warning("APIC: NR_CPUS/possible_cpus limit of %i " + "reached. Processor %d/0x%x ignored.\n", + max, thiscpu, apicid); + } disabled_cpus++; return -EINVAL; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: Bogus "APIC: NR_CPUS/possible_cpus limit of 4 reached" messages 2016-10-07 13:55 ` Thomas Gleixner @ 2016-10-07 14:09 ` Markus Trippelsdorf 2016-10-08 10:24 ` [tip:x86/urgent] x86/apic: Prevent pointless warning messages tip-bot for Thomas Gleixner 1 sibling, 0 replies; 7+ messages in thread From: Markus Trippelsdorf @ 2016-10-07 14:09 UTC (permalink / raw) To: Thomas Gleixner Cc: One Thousand Gnomes, Gu Zheng, linux-acpi, linux-kernel, Dou Liyang On 2016.10.07 at 15:55 +0200, Thomas Gleixner wrote: > On Fri, 7 Oct 2016, Markus Trippelsdorf wrote: > > On 2016.10.06 at 13:52 +0200, Markus Trippelsdorf wrote: > > > On 2016.10.06 at 12:48 +0100, One Thousand Gnomes wrote: > > > > On Thu, 6 Oct 2016 13:27:37 +0200 > > > > Markus Trippelsdorf <markus@trippelsdorf.de> wrote: > > > > > > > > > On current trunk I get during boot: > > > > > > > > > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 4/0x84 ignored. > > > > > [ 0.000000] APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 5/0x85 ignored. > > > > > > > > > > I don't think these messages make much sense on a 4-core machine. > > > > > > > > > > > > > Four cores with or without hyperthreading ? > > > > > > Without. This is a rather old AMD machine (AMD Phenom II X4 955). > > That's due to the recent cpuid -> nodeid changes. The patch below should > fix it. Indeed it does. Thanks for the quick fix. -- Markus ^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:x86/urgent] x86/apic: Prevent pointless warning messages 2016-10-07 13:55 ` Thomas Gleixner 2016-10-07 14:09 ` Markus Trippelsdorf @ 2016-10-08 10:24 ` tip-bot for Thomas Gleixner 1 sibling, 0 replies; 7+ messages in thread From: tip-bot for Thomas Gleixner @ 2016-10-08 10:24 UTC (permalink / raw) To: linux-tip-commits Cc: hpa, mingo, douly.fnst, guz.fnst, markus, tglx, linux-kernel, gnomes Commit-ID: df610d678893c85b82d3a68eea0d87dd4e03e615 Gitweb: http://git.kernel.org/tip/df610d678893c85b82d3a68eea0d87dd4e03e615 Author: Thomas Gleixner <tglx@linutronix.de> AuthorDate: Fri, 7 Oct 2016 15:55:13 +0200 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Sat, 8 Oct 2016 12:18:36 +0200 x86/apic: Prevent pointless warning messages Markus reported that he sees new warnings: APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 4/0x84 ignored. APIC: NR_CPUS/possible_cpus limit of 4 reached. Processor 5/0x85 ignored. This comes from the recent persistant cpuid - nodeid changes. The code which emits the warning has been called prior to these changes only for enabled processors. Now it's called for disabled processors as well to get the possible cpu accounting correct. So if the kernel is compiled for the number of actual available/enabled CPUs and the BIOS reports disabled CPUs as well then the above warnings are printed. That's a pointless exercise as it only makes sense if there are more CPUs enabled than the kernel supports. Nake the warning conditional on enabled processors so we are back to the state before these changes. Fixes: 8f54969dc8d6 ("x86/acpi: Introduce persistent storage for cpuid <-> apicid mapping") Reported-and-tested-by: Markus Trippelsdorf <markus@trippelsdorf.de> Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> Cc: Dou Liyang <douly.fnst@cn.fujitsu.com> Cc: linux-acpi@vger.kernel.org Cc: Gu Zheng <guz.fnst@cn.fujitsu.com> Link: http://lkml.kernel.org/r/alpine.DEB.2.20.1610071549330.19804@nanos Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- arch/x86/kernel/apic/apic.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index f266b8a..88c657b 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2128,9 +2128,11 @@ int __generic_processor_info(int apicid, int version, bool enabled) if (num_processors >= nr_cpu_ids) { int thiscpu = max + disabled_cpus; - pr_warning( - "APIC: NR_CPUS/possible_cpus limit of %i reached." - " Processor %d/0x%x ignored.\n", max, thiscpu, apicid); + if (enabled) { + pr_warning("APIC: NR_CPUS/possible_cpus limit of %i " + "reached. Processor %d/0x%x ignored.\n", + max, thiscpu, apicid); + } disabled_cpus++; return -EINVAL; ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-08 10:25 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-10-06 11:27 Bogus "APIC: NR_CPUS/possible_cpus limit of 4 reached" messages Markus Trippelsdorf 2016-10-06 11:48 ` One Thousand Gnomes 2016-10-06 11:52 ` Markus Trippelsdorf 2016-10-07 13:26 ` Markus Trippelsdorf 2016-10-07 13:55 ` Thomas Gleixner 2016-10-07 14:09 ` Markus Trippelsdorf 2016-10-08 10:24 ` [tip:x86/urgent] x86/apic: Prevent pointless warning messages tip-bot for Thomas Gleixner
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.