All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lib: add tst_res_hexd for newlib
Date: Thu, 6 Oct 2016 14:35:29 +0200	[thread overview]
Message-ID: <20161006123528.GA10467@rei.lan> (raw)
In-Reply-To: <77e055a73816d095647ced78f9444932845f370c.1475754253.git.jstancek@redhat.com>

Hi!
> Locking mutex isn't necessary for oldlib, because
> we already lock at tst_res__ level.

Well, technically that would mean that the lines from hexdump may be
interleaved with other messages but in reality I doubt that this would
ever happen.

We should propably add a note to test-writing-guidelines, apart from
that this looks OK. Acked.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-10-06 12:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 11:46 [LTP] [PATCH] lib: add tst_res_hexd for newlib Jan Stancek
2016-10-06 12:35 ` Cyril Hrubis [this message]
2016-10-06 14:08   ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161006123528.GA10467@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.