From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lib: add tst_res_hexd for newlib
Date: Thu, 6 Oct 2016 10:08:09 -0400 (EDT) [thread overview]
Message-ID: <618636125.838615.1475762889407.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20161006123528.GA10467@rei.lan>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Thursday, 6 October, 2016 2:35:29 PM
> Subject: Re: [PATCH] lib: add tst_res_hexd for newlib
>
> Hi!
> > Locking mutex isn't necessary for oldlib, because
> > we already lock at tst_res__ level.
>
> Well, technically that would mean that the lines from hexdump may be
> interleaved with other messages but in reality I doubt that this would
> ever happen.
>
> We should propably add a note to test-writing-guidelines, apart from
> that this looks OK. Acked.
Pushed.
Regards,
Jan
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
prev parent reply other threads:[~2016-10-06 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 11:46 [LTP] [PATCH] lib: add tst_res_hexd for newlib Jan Stancek
2016-10-06 12:35 ` Cyril Hrubis
2016-10-06 14:08 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=618636125.838615.1475762889407.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.