All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: timur@codeaurora.org, cov@codeaurora.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative"
Date: Thu, 6 Oct 2016 22:37:34 +0100	[thread overview]
Message-ID: <20161006213734.GM19539@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1475789429-11414-1-git-send-email-okaya@codeaurora.org>

On Thu, Oct 06, 2016 at 05:30:29PM -0400, Sinan Kaya wrote:
> This reverts commit acc29fb8f792 ("debugfs: ->d_parent is never NULL or
> negative") as it breaks the debugfs_remove_recursive API as show in the
> callstack below.

NAK.  Fix your code, don't break global asserts.

WARNING: multiple messages have this Message-ID (diff)
From: viro@ZenIV.linux.org.uk (Al Viro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative"
Date: Thu, 6 Oct 2016 22:37:34 +0100	[thread overview]
Message-ID: <20161006213734.GM19539@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1475789429-11414-1-git-send-email-okaya@codeaurora.org>

On Thu, Oct 06, 2016 at 05:30:29PM -0400, Sinan Kaya wrote:
> This reverts commit acc29fb8f792 ("debugfs: ->d_parent is never NULL or
> negative") as it breaks the debugfs_remove_recursive API as show in the
> callstack below.

NAK.  Fix your code, don't break global asserts.

  reply	other threads:[~2016-10-06 21:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 21:30 [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Sinan Kaya
2016-10-06 21:30 ` Sinan Kaya
2016-10-06 21:37 ` Al Viro [this message]
2016-10-06 21:37   ` Al Viro
2016-10-06 21:41   ` Sinan Kaya
2016-10-06 21:41     ` Sinan Kaya
2016-10-06 21:56     ` Sinan Kaya
2016-10-06 21:56       ` Sinan Kaya
2016-10-06 22:11       ` Sinan Kaya
2016-10-06 22:11         ` Sinan Kaya
2016-10-06 22:00     ` Al Viro
2016-10-06 22:00       ` Al Viro
2016-10-06 22:37       ` Al Viro
2016-10-06 22:37         ` Al Viro
2016-10-06 22:41         ` Al Viro
2016-10-06 22:41           ` Al Viro
2016-10-06 23:21           ` Sinan Kaya
2016-10-06 23:21             ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161006213734.GM19539@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=cov@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okaya@codeaurora.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.