From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure
Date: Fri, 7 Oct 2016 10:38:53 +0200 [thread overview]
Message-ID: <20161007083853.GH4684@lukather> (raw)
In-Reply-To: <20161006160629.11198-3-wens@csie.org>
Hi,
On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote:
> +struct sun4i_tcon_quirks {
> + bool is_sun5i; /* sun5i has undocumented mux */
> + bool has_channel_1; /* a33 does not have channel 1 */
> + bool has_bypass_src; /* has separate input bypassing CEU */
> + bool has_dma_src; /* has DMA input */
> +};
> +
I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't
really relate to what we're doing there, is redundant with the
compatible, and render the other quirks name useless, since we could
just have is_sun.i quirks and deal with that (which is essentially
what we were doing before).
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161007/ea01852f/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure
Date: Fri, 7 Oct 2016 10:38:53 +0200 [thread overview]
Message-ID: <20161007083853.GH4684@lukather> (raw)
In-Reply-To: <20161006160629.11198-3-wens-jdAy2FN1RRM@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
Hi,
On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote:
> +struct sun4i_tcon_quirks {
> + bool is_sun5i; /* sun5i has undocumented mux */
> + bool has_channel_1; /* a33 does not have channel 1 */
> + bool has_bypass_src; /* has separate input bypassing CEU */
> + bool has_dma_src; /* has DMA input */
> +};
> +
I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't
really relate to what we're doing there, is redundant with the
compatible, and render the other quirks name useless, since we could
just have is_sun.i quirks and deal with that (which is essentially
what we were doing before).
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure
Date: Fri, 7 Oct 2016 10:38:53 +0200 [thread overview]
Message-ID: <20161007083853.GH4684@lukather> (raw)
In-Reply-To: <20161006160629.11198-3-wens@csie.org>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
Hi,
On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote:
> +struct sun4i_tcon_quirks {
> + bool is_sun5i; /* sun5i has undocumented mux */
> + bool has_channel_1; /* a33 does not have channel 1 */
> + bool has_bypass_src; /* has separate input bypassing CEU */
> + bool has_dma_src; /* has DMA input */
> +};
> +
I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't
really relate to what we're doing there, is redundant with the
compatible, and render the other quirks name useless, since we could
just have is_sun.i quirks and deal with that (which is essentially
what we were doing before).
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-07 8:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 16:06 [PATCH 0/9] drm/sun4i: Support first display pipeline on sun6i Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` [PATCH 1/9] drm/sun4i: sun6i-drc: Support DRC on A31 and A31s Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-10 14:45 ` Rob Herring
2016-10-10 14:45 ` Rob Herring
2016-10-10 14:45 ` Rob Herring
2016-10-06 16:06 ` [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-07 8:38 ` Maxime Ripard [this message]
2016-10-07 8:38 ` Maxime Ripard
2016-10-07 8:38 ` Maxime Ripard
2016-10-11 9:16 ` Chen-Yu Tsai
2016-10-11 9:16 ` Chen-Yu Tsai
2016-10-11 9:16 ` Chen-Yu Tsai
2016-10-11 9:36 ` Maxime Ripard
2016-10-11 9:36 ` Maxime Ripard
2016-10-11 9:36 ` Maxime Ripard
2016-10-06 16:06 ` [PATCH 3/9] drm/sun4i: Put dotclock range into tcon quirks and check against them Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-07 8:54 ` Maxime Ripard
2016-10-07 8:54 ` Maxime Ripard
2016-10-07 8:54 ` Maxime Ripard
2016-10-06 16:06 ` [PATCH 4/9] drm/sun4i: Add compatible string for A31/A31s TCON (timing controller) Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-07 8:55 ` Maxime Ripard
2016-10-07 8:55 ` Maxime Ripard
2016-10-07 8:55 ` Maxime Ripard
2016-10-06 16:06 ` [PATCH 5/9] drm/sun4i: Add compatible strings for A31/A31s display pipelines Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-10 14:49 ` Rob Herring
2016-10-10 14:49 ` Rob Herring
2016-10-10 14:49 ` Rob Herring
2016-10-06 16:06 ` [PATCH 6/9] ARM: dts: sun6i: Sort pinmux setting nodes Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-07 8:57 ` Maxime Ripard
2016-10-07 8:57 ` Maxime Ripard
2016-10-07 8:57 ` Maxime Ripard
2016-10-06 16:06 ` [PATCH 7/9] ARM: dts: sun6i: Add device nodes for first display pipeline Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` [PATCH 8/9] ARM: dts: sun6i: Add A31 LCD0 RGB888 pins Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` [PATCH 9/9] [DO NOT MERGE] ARM: dts: sun6i: Enable 7" LCD panel on Sinlinx SinA31s Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:06 ` Chen-Yu Tsai
2016-10-06 16:23 ` [linux-sunxi] " Icenowy Zheng
2016-10-06 16:23 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007083853.GH4684@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.