[PATCH] multipath-tools: add IBM/FlashSystem to hwtable

[PATCH] multipath-tools: add IBM/FlashSystem to hwtable

[Xose Vazquez Perez]

System          Vendor Product          Multipathing Policy
=============== ====== ================ =======================
FlashSystem 710 IBM    FlashSystem      Symmetric Active/Active
FlashSystem 720 IBM    FlashSystem      Symmetric Active/Active
FlashSystem 810 IBM    FlashSystem      Symmetric Active/Active
FlashSystem 820 IBM    FlashSystem      Symmetric Active/Active
FlashSystem 840 IBM    FlashSystem-9840 Symmetric Active/Active
FlashSystem 900 IBM    FlashSystem-9840 Symmetric Active/Active

Based on documentation from the manufacturer:
http://www.redbooks.ibm.com/redbooks/pdfs/sg248271.pdf

Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index e1b055a..ff6989d 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -522,6 +522,13 @@ static struct hwentry default_hw[] = {
 		.no_path_retry = NO_PATH_RETRY_QUEUE,
 		.pgpolicy      = MULTIBUS,
 	},
+	{
+		/* FlashSystem 710/720/810/820/840/900 */
+		.vendor        = "IBM",
+		.product       = "FlashSystem",
+		.no_path_retry = NO_PATH_RETRY_FAIL,
+		.pgpolicy      = MULTIBUS,
+	},
 		/*
 		 * IBM Power Virtual SCSI Devices
 		 *
-- 
2.10.1

Re: [PATCH] multipath-tools: add IBM/FlashSystem to hwtable

[Steffen Maier]

On 10/07/2016 03:15 PM, Xose Vazquez Perez wrote:
> System          Vendor Product          Multipathing Policy
> =============== ====== ================ =======================
> FlashSystem 710 IBM    FlashSystem      Symmetric Active/Active
> FlashSystem 720 IBM    FlashSystem      Symmetric Active/Active
> FlashSystem 810 IBM    FlashSystem      Symmetric Active/Active
> FlashSystem 820 IBM    FlashSystem      Symmetric Active/Active
> FlashSystem 840 IBM    FlashSystem-9840 Symmetric Active/Active
> FlashSystem 900 IBM    FlashSystem-9840 Symmetric Active/Active
>
> Based on documentation from the manufacturer:
> http://www.redbooks.ibm.com/redbooks/pdfs/sg248271.pdf

IBM RedBooks are more like descriptions for one particular use case as 
described in the book rather than reference manuals.

Product documentation is elsewhere and also updated more often (like 
each product release) than a RedBook.
E.g. for IBM FlashSystem 900:
http://www.ibm.com/support/knowledgecenter/STKMQB/com.ibm.storage.flashsystem900.1.2.doc/tms_multipathing.html

You'll notice that we from Linux on s390x have a bit different 
recommendations for some of the values (no_path_retry actually depends 
on whether you have a cluster software/filesystem that can cope with EIO 
on last-path-loss. Currently, I see the default without that, i.e. 
non-clustered from which we would like to hide any path issues).

Is there some way to have "dependent" settings?

> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index e1b055a..ff6989d 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -522,6 +522,13 @@ static struct hwentry default_hw[] = {
>  		.no_path_retry = NO_PATH_RETRY_QUEUE,
>  		.pgpolicy      = MULTIBUS,
>  	},
> +	{
> +		/* FlashSystem 710/720/810/820/840/900 */
> +		.vendor        = "IBM",
> +		.product       = "FlashSystem",
> +		.no_path_retry = NO_PATH_RETRY_FAIL,
> +		.pgpolicy      = MULTIBUS,
> +	},
>  		/*
>  		 * IBM Power Virtual SCSI Devices
>  		 *
>

-- 
Mit freundlichen Grüßen / Kind regards
Steffen Maier

Linux on z Systems Development

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [PATCH] multipath-tools: add IBM/FlashSystem to hwtable

[Xose Vazquez Perez]

On 10/07/2016 04:24 PM, Steffen Maier wrote:

> You'll notice that we from Linux on s390x have a bit different recommendations
> for some of the values (no_path_retry actually depends on whether you have a
> cluster software/filesystem that can cope with EIO on last-path-loss. Currently,
> I see the default without that, i.e. non-clustered from which we would like to hide any path issues).

This has to be modified manually.

> Is there some way to have "dependent" settings?

No. multipath.conf is mainly static.
Only two options are dynamically reconfigured, ALUA-prio and the hardware handler
with "detect_prio" and "retain_attached_hw_handler".