[PATCH] multipath-tools: add FUJITSU/ETERNUS 2000/4000/8000 to hwtable

[PATCH] multipath-tools: add FUJITSU/ETERNUS 2000/4000/8000 to hwtable

[Xose Vazquez Perez]

Based on documentation provided by the manufacturer:
http://storage-system.fujitsu.com/global/manual/diskarray/pdf/p3am-3192-en.pdf

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index e1ed7ef..367aa0a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -268,6 +268,14 @@ static struct hwentry default_hw[] = {
 		.product       = "FC2502",
 		.pgpolicy      = MULTIBUS,
 	},
+	{
+		.vendor        = "FUJITSU",
+		.product       = "E[248]000",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.pgfailback    = -FAILBACK_IMMEDIATE,
+		.no_path_retry = 10,
+		.prio_name     = PRIO_ALUA,
+	},
 	/*
 	 * Hitachi
 	 *
-- 
2.10.1

Re: [PATCH] multipath-tools: add FUJITSU/ETERNUS 2000/4000/8000 to hwtable

[Sebastian Herbszt]

Vazquez Perez wrote:
> Based on documentation provided by the manufacturer:
> http://storage-system.fujitsu.com/global/manual/diskarray/pdf/p3am-3192-en.pdf
> 
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index e1ed7ef..367aa0a 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -268,6 +268,14 @@ static struct hwentry default_hw[] = {
>  		.product       = "FC2502",
>  		.pgpolicy      = MULTIBUS,
>  	},
> +	{
> +		.vendor        = "FUJITSU",
> +		.product       = "E[248]000",
> +		.pgpolicy      = GROUP_BY_PRIO,
> +		.pgfailback    = -FAILBACK_IMMEDIATE,
> +		.no_path_retry = 10,
> +		.prio_name     = PRIO_ALUA,
> +	},
>  	/*
>  	 * Hitachi
>  	 *

Now that you dropped the path selector as suggested back in July [1]
why not merge this with the ETERNUS DX entry?

[1] https://www.redhat.com/archives/dm-devel/2016-July/msg00595.html

Sebastian

Re: [PATCH] multipath-tools: add FUJITSU/ETERNUS 2000/4000/8000 to hwtable

[Xose Vazquez Perez]

On 10/08/2016 10:30 PM, Sebastian Herbszt wrote:

> Now that you dropped the path selector as suggested back in July [1]
> why not merge this with the ETERNUS DX entry?
> 
> [1] https://www.redhat.com/archives/dm-devel/2016-July/msg00595.html

If a lot of devices share the same configuration some flexibility is lost.
I do not have a single answer.
It's a tricky balance between to group devices and don't lose flexibility.

ETERNUS 2000/4000/8000 are very old and a different generation of devices,
the next year they are going to be declared "EOL" in Japan. In the rest of the
world it was at the beginning of 2015, IIRC.