All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Elise Lennion <elise.lennion@gmail.com>
Cc: aditya.shankar@microchip.com, ganesh.krishna@microchip.com,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 3/4] staging: wilc1000: Replace printk() with pr_info().
Date: Sun, 9 Oct 2016 16:32:44 +0200	[thread overview]
Message-ID: <20161009143244.GA4541@kroah.com> (raw)
In-Reply-To: <20161009031023.GA11944@lennorien.com>

On Sun, Oct 09, 2016 at 12:10:23AM -0300, Elise Lennion wrote:
> Fix checkpatch warning:
> 
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> 
> Replace printk(KERN_INFO...) by pr_info() for more uniform error reporting.
> 
> Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
> ---
>  drivers/staging/wilc1000/wilc_debugfs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

You need to put below the --- line what changed in v2 of this patch.

thanks,

greg k-h


  reply	other threads:[~2016-10-09 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-09  3:10 [PATCH v2 3/4] staging: wilc1000: Replace printk() with pr_info() Elise Lennion
2016-10-09 14:32 ` Greg KH [this message]
2016-10-10  3:49   ` Elise Lennion
  -- strict thread matches above, loose matches on Subject: below --
2016-10-10  3:38 Elise Lennion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009143244.GA4541@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aditya.shankar@microchip.com \
    --cc=elise.lennion@gmail.com \
    --cc=ganesh.krishna@microchip.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.