* [PATCH v2 3/4] staging: wilc1000: Replace printk() with pr_info().
@ 2016-10-09 3:10 Elise Lennion
2016-10-09 14:32 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Elise Lennion @ 2016-10-09 3:10 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh, outreachy-kernel
Fix checkpatch warning:
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Replace printk(KERN_INFO...) by pr_info() for more uniform error reporting.
Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
---
drivers/staging/wilc1000/wilc_debugfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index 802bb1d..07260c4 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -62,16 +62,16 @@ static ssize_t wilc_debug_level_write(struct file *filp, const char __user *buf,
return ret;
if (flag > DBG_LEVEL_ALL) {
- printk("%s, value (0x%08x) is out of range, stay previous flag (0x%08x)\n", __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
+ pr_info("%s, value (0x%08x) is out of range, stay previous flag (0x%08x)\n", __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
return -EINVAL;
}
atomic_set(&WILC_DEBUG_LEVEL, (int)flag);
if (flag == 0)
- printk(KERN_INFO "Debug-level disabled\n");
+ pr_info("Debug-level disabled\n");
else
- printk(KERN_INFO "Debug-level enabled\n");
+ pr_info("Debug-level enabled\n");
return count;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 3/4] staging: wilc1000: Replace printk() with pr_info().
2016-10-09 3:10 [PATCH v2 3/4] staging: wilc1000: Replace printk() with pr_info() Elise Lennion
@ 2016-10-09 14:32 ` Greg KH
2016-10-10 3:49 ` Elise Lennion
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2016-10-09 14:32 UTC (permalink / raw)
To: Elise Lennion; +Cc: aditya.shankar, ganesh.krishna, outreachy-kernel
On Sun, Oct 09, 2016 at 12:10:23AM -0300, Elise Lennion wrote:
> Fix checkpatch warning:
>
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> Replace printk(KERN_INFO...) by pr_info() for more uniform error reporting.
>
> Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_debugfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
You need to put below the --- line what changed in v2 of this patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 3/4] staging: wilc1000: Replace printk() with pr_info().
2016-10-09 14:32 ` Greg KH
@ 2016-10-10 3:49 ` Elise Lennion
0 siblings, 0 replies; 4+ messages in thread
From: Elise Lennion @ 2016-10-10 3:49 UTC (permalink / raw)
To: Greg KH; +Cc: aditya.shankar, ganesh.krishna, outreachy-kernel
On Sun, Oct 09, 2016 at 04:32:44PM +0200, Greg KH wrote:
> You need to put below the --- line what changed in v2 of this patch.
>
> thanks,
>
> greg k-h
In this one I only included the first pr_info() in the commit.
Sent another patch with the description of v2.
elise
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 3/4] staging: wilc1000: Replace printk() with pr_info().
@ 2016-10-10 3:38 Elise Lennion
0 siblings, 0 replies; 4+ messages in thread
From: Elise Lennion @ 2016-10-10 3:38 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh, outreachy-kernel
Fix checkpatch warning:
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Replace printk(KERN_INFO...) by pr_info() for more uniform error reporting.
Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
---
v2: Added the first pr_info() to the commit, v1 contained only the last two.
drivers/staging/wilc1000/wilc_debugfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index 802bb1d..07260c4 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -62,16 +62,16 @@ static ssize_t wilc_debug_level_write(struct file *filp, const char __user *buf,
return ret;
if (flag > DBG_LEVEL_ALL) {
- printk("%s, value (0x%08x) is out of range, stay previous flag (0x%08x)\n", __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
+ pr_info("%s, value (0x%08x) is out of range, stay previous flag (0x%08x)\n", __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
return -EINVAL;
}
atomic_set(&WILC_DEBUG_LEVEL, (int)flag);
if (flag == 0)
- printk(KERN_INFO "Debug-level disabled\n");
+ pr_info("Debug-level disabled\n");
else
- printk(KERN_INFO "Debug-level enabled\n");
+ pr_info("Debug-level enabled\n");
return count;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-10 3:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-09 3:10 [PATCH v2 3/4] staging: wilc1000: Replace printk() with pr_info() Elise Lennion
2016-10-09 14:32 ` Greg KH
2016-10-10 3:49 ` Elise Lennion
-- strict thread matches above, loose matches on Subject: below --
2016-10-10 3:38 Elise Lennion
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.