All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: ks7010: Add blank line after variable declarations.
@ 2016-10-05 20:48 Elise Lennion
  2016-10-09 14:45 ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Elise Lennion @ 2016-10-05 20:48 UTC (permalink / raw)
  To: gregkh, outreachy-kernel

Fix checkpatch WARNING: Missing a blank line after declarations.

Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
---
 drivers/staging/ks7010/ks7010_sdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 81c46f4..db5e632 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -1117,6 +1117,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
 	int ret;
 	struct ks_sdio_card *card;
 	struct ks_wlan_private *priv;
+
 	DPRINTK(1, "ks7010_sdio_remove()\n");
 
 	card = sdio_get_drvdata(func);
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] staging: ks7010: Add blank line after variable declarations.
  2016-10-05 20:48 [PATCH v2] staging: ks7010: Add blank line after variable declarations Elise Lennion
@ 2016-10-09 14:45 ` Greg KH
  2016-10-10  3:45   ` Elise Lennion
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-10-09 14:45 UTC (permalink / raw)
  To: Elise Lennion; +Cc: outreachy-kernel

On Wed, Oct 05, 2016 at 05:48:59PM -0300, Elise Lennion wrote:
> Fix checkpatch WARNING: Missing a blank line after declarations.
> 
> Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 1 +
>  1 file changed, 1 insertion(+)

You need to say what changed in v2, otherwise we have no idea :(



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] staging: ks7010: Add blank line after variable declarations.
@ 2016-10-10  3:33 Elise Lennion
  2016-10-10  7:08 ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Elise Lennion @ 2016-10-10  3:33 UTC (permalink / raw)
  To: gregkh, outreachy-kernel

Fix checkpatch WARNING: Missing a blank line after declarations.

Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
---

v2: Fixed my name, was signing as Elise-Lennion before.

 drivers/staging/ks7010/ks7010_sdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 81c46f4..db5e632 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -1117,6 +1117,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
 	int ret;
 	struct ks_sdio_card *card;
 	struct ks_wlan_private *priv;
+
 	DPRINTK(1, "ks7010_sdio_remove()\n");
 
 	card = sdio_get_drvdata(func);
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] staging: ks7010: Add blank line after variable declarations.
  2016-10-09 14:45 ` Greg KH
@ 2016-10-10  3:45   ` Elise Lennion
  2016-10-10  6:40     ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 6+ messages in thread
From: Elise Lennion @ 2016-10-10  3:45 UTC (permalink / raw)
  To: Greg KH; +Cc: outreachy-kernel

On Sun, Oct 09, 2016 at 04:45:06PM +0200, Greg KH wrote:

> You need to say what changed in v2, otherwise we have no idea :(
> 

In this one I just fixed my name, was signing with my git username before.

Is just replying this e-mail enough? Also sent another patch with the same subject and the v2 description included.

thanks,

elise


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: Add blank line after variable declarations.
  2016-10-10  3:45   ` Elise Lennion
@ 2016-10-10  6:40     ` Julia Lawall
  0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-10-10  6:40 UTC (permalink / raw)
  To: Elise Lennion; +Cc: Greg KH, outreachy-kernel



On Mon, 10 Oct 2016, Elise Lennion wrote:

> On Sun, Oct 09, 2016 at 04:45:06PM +0200, Greg KH wrote:
>
> > You need to say what changed in v2, otherwise we have no idea :(
> >
>
> In this one I just fixed my name, was signing with my git username before.
>
> Is just replying this e-mail enough? Also sent another patch with the same subject and the v2 description included.

It's better to just always send a v2.

julia

>
> thanks,
>
> elise
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161010034546.GA5524%40lennorien.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] staging: ks7010: Add blank line after variable declarations.
  2016-10-10  3:33 Elise Lennion
@ 2016-10-10  7:08 ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2016-10-10  7:08 UTC (permalink / raw)
  To: Elise Lennion; +Cc: outreachy-kernel

On Mon, Oct 10, 2016 at 12:33:33AM -0300, Elise Lennion wrote:
> Fix checkpatch WARNING: Missing a blank line after declarations.
> 
> Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
> ---
> 
> v2: Fixed my name, was signing as Elise-Lennion before.
> 
>  drivers/staging/ks7010/ks7010_sdio.c | 1 +
>  1 file changed, 1 insertion(+)

This change is already in my tree :(


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-10-10  7:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-05 20:48 [PATCH v2] staging: ks7010: Add blank line after variable declarations Elise Lennion
2016-10-09 14:45 ` Greg KH
2016-10-10  3:45   ` Elise Lennion
2016-10-10  6:40     ` [Outreachy kernel] " Julia Lawall
  -- strict thread matches above, loose matches on Subject: below --
2016-10-10  3:33 Elise Lennion
2016-10-10  7:08 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.