All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mihaela Muraru <mihaela.muraru21@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] Staging: ks7010: Replace printk with netdev_*
Date: Sun, 9 Oct 2016 16:48:22 +0200	[thread overview]
Message-ID: <20161009144822.GA15170@kroah.com> (raw)
In-Reply-To: <20161007205559.GA11103@domino-MS-16Y1>

On Fri, Oct 07, 2016 at 11:55:59PM +0300, Mihaela Muraru wrote:
> This is a patch to ks_hostif.c file that fixes up a checkpatch.pl
> 
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
> 
> For netdev devices netdev_info and netdev_warn is preferred over
> printk(KERN_INFO/WARN..).
> 
> Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)

This no longer applies to my tree, can you rebase against the
staging-testing branch and resend it?

thanks,

greg k-h


  reply	other threads:[~2016-10-09 14:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 20:55 [PATCH] Staging: ks7010: Replace printk with netdev_* Mihaela Muraru
2016-10-09 14:48 ` Greg Kroah-Hartman [this message]
2016-10-09 20:37   ` Muraru Mihaela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009144822.GA15170@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=mihaela.muraru21@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.