[PATCH] Staging: ks7010: Replace printk with netdev_*

[PATCH] Staging: ks7010: Replace printk with netdev_*

[Mihaela Muraru]

This is a patch to ks_hostif.c file that fixes up a checkpatch.pl

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

For netdev devices netdev_info and netdev_warn is preferred over
printk(KERN_INFO/WARN..).

Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
---
 drivers/staging/ks7010/ks_hostif.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index c57ca58..8798b63 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -476,8 +476,7 @@ void hostif_data_indication(struct ks_wlan_private *priv)
 			skb->dev->last_rx = jiffies;
 			netif_rx(skb);
 		} else {
-			printk(KERN_WARNING
-			       "ks_wlan: Memory squeeze, dropping packet.\n");
+			netdev_warn(skb->dev, "ks_wlan: Memory squeeze, dropping packet.\n");
 			priv->nstats.rx_dropped++;
 		}
 		break;
@@ -511,8 +510,7 @@ void hostif_data_indication(struct ks_wlan_private *priv)
 			skb->dev->last_rx = jiffies;
 			netif_rx(skb);
 		} else {
-			printk(KERN_WARNING
-			       "ks_wlan: Memory squeeze, dropping packet.\n");
+			netdev_warn(skb->dev, "ks_wlan: Memory squeeze, dropping packet.\n");
 			priv->nstats.rx_dropped++;
 		}
 		break;
@@ -560,8 +558,7 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
 		dev->dev_addr[5] = priv->eth_addr[5];
 		dev->dev_addr[6] = 0x00;
 		dev->dev_addr[7] = 0x00;
-		printk(KERN_INFO
-		       "ks_wlan: MAC ADDRESS = %02x:%02x:%02x:%02x:%02x:%02x\n",
+		netdev_info(dev, "ks_wlan: MAC ADDRESS = %02x:%02x:%02x:%02x:%02x:%02x\n",
 		       priv->eth_addr[0], priv->eth_addr[1], priv->eth_addr[2],
 		       priv->eth_addr[3], priv->eth_addr[4], priv->eth_addr[5]);
 		break;
@@ -571,7 +568,7 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
 		priv->version_size = priv->rx_size;
 		memcpy(priv->firmware_version, priv->rxp, priv->rx_size);
 		priv->firmware_version[priv->rx_size] = '\0';
-		printk(KERN_INFO "ks_wlan: firmware ver. = %s\n",
+		netdev_info(dev, "ks_wlan: firmware ver. = %s\n",
 		       priv->firmware_version);
 		hostif_sme_enqueue(priv, SME_GET_PRODUCT_VERSION);
 		/* wake_up_interruptible_all(&priv->confirm_wait); */
-- 
2.7.4

Re: [PATCH] Staging: ks7010: Replace printk with netdev_*

[Greg Kroah-Hartman]

On Fri, Oct 07, 2016 at 11:55:59PM +0300, Mihaela Muraru wrote:
> This is a patch to ks_hostif.c file that fixes up a checkpatch.pl
> 
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
> 
> For netdev devices netdev_info and netdev_warn is preferred over
> printk(KERN_INFO/WARN..).
> 
> Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)

This no longer applies to my tree, can you rebase against the
staging-testing branch and resend it?

thanks,

greg k-h

Re: [PATCH] Staging: ks7010: Replace printk with netdev_*

[Muraru Mihaela]

On Sun, Oct 09, 2016 at 04:48:22PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 07, 2016 at 11:55:59PM +0300, Mihaela Muraru wrote:
> > This is a patch to ks_hostif.c file that fixes up a checkpatch.pl
> > 
> > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> > dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
> > 
> > For netdev devices netdev_info and netdev_warn is preferred over
> > printk(KERN_INFO/WARN..).
> > 
> > Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> > ---
> >  drivers/staging/ks7010/ks_hostif.c | 11 ++++-------
> >  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> This no longer applies to my tree, can you rebase against the
> staging-testing branch and resend it?
> 
> thanks,
> 
> greg k-h

I will resend it, thank you for telling me.

mihaela