From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-arm-kernel@lists.infradead.org,
Michael Schmitz <schmitzmic@gmail.com>,
Ondrej Zary <linux@rainbow-software.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 07/12] scsi/ncr5380: Store IO ports and addresses in host private data
Date: Mon, 10 Oct 2016 10:19:49 +0100 [thread overview]
Message-ID: <20161010091949.GZ1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <5c9f6b4913bc8bc4938d2de0bb19d4289226ec26.1476051962.git.fthain@telegraphics.com.au>
On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote:
> The various 5380 drivers inconsistently store register pointers
> either in the Scsi_Host struct "legacy crap" area or in special,
> board-specific members of the NCR5380_hostdata struct. Uniform
> use of the latter struct makes for simpler and faster code (see
> the following patches) and helps to reduce use of the
> NCR5380_implementation_fields macro.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
> Tested-by: Ondrej Zary <linux@rainbow-software.org>
> Tested-by: Michael Schmitz <schmitzmic@gmail.com>
> ---
> drivers/scsi/arm/cumana_1.c | 60 ++++++++++++++++++++--------------------
> drivers/scsi/arm/oak.c | 23 ++++++++--------
For these two,
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 07/12] scsi/ncr5380: Store IO ports and addresses in host private data
Date: Mon, 10 Oct 2016 10:19:49 +0100 [thread overview]
Message-ID: <20161010091949.GZ1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <5c9f6b4913bc8bc4938d2de0bb19d4289226ec26.1476051962.git.fthain@telegraphics.com.au>
On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote:
> The various 5380 drivers inconsistently store register pointers
> either in the Scsi_Host struct "legacy crap" area or in special,
> board-specific members of the NCR5380_hostdata struct. Uniform
> use of the latter struct makes for simpler and faster code (see
> the following patches) and helps to reduce use of the
> NCR5380_implementation_fields macro.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
> Tested-by: Ondrej Zary <linux@rainbow-software.org>
> Tested-by: Michael Schmitz <schmitzmic@gmail.com>
> ---
> drivers/scsi/arm/cumana_1.c | 60 ++++++++++++++++++++--------------------
> drivers/scsi/arm/oak.c | 23 ++++++++--------
For these two,
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-10-10 9:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 4:46 [PATCH v3 00/12] Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` [PATCH v3 04/12] scsi/ncr5380: Simplify register polling limit Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` [PATCH v3 05/12] scsi/ncr5380: Increase " Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` [PATCH v3 03/12] scsi/atari_scsi: Make device register accessors re-entrant Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` [PATCH v3 02/12] scsi/cumana_1: Remove unused cumanascsi_setup() function Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 9:11 ` Russell King - ARM Linux
2016-10-10 9:11 ` Russell King - ARM Linux
2016-10-10 9:11 ` Russell King - ARM Linux
2016-10-10 4:46 ` [PATCH v3 01/12] scsi/g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` [PATCH v3 07/12] scsi/ncr5380: Store IO ports and addresses in host private data Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 9:19 ` Russell King - ARM Linux [this message]
2016-10-10 9:19 ` Russell King - ARM Linux
2016-10-10 4:46 ` [PATCH v3 11/12] scsi/ncr5380: Use correct types for DMA routines Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 9:15 ` Russell King - ARM Linux
2016-10-10 9:15 ` Russell King - ARM Linux
2016-10-10 9:15 ` Russell King - ARM Linux
2016-10-10 4:46 ` [PATCH v3 10/12] scsi/ncr5380: Expedite register polling Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 9:17 ` Russell King - ARM Linux
2016-10-10 9:17 ` Russell King - ARM Linux
2016-10-10 9:17 ` Russell King - ARM Linux
2016-10-10 22:57 ` Finn Thain
2016-10-10 22:57 ` Finn Thain
2016-10-10 4:46 ` [PATCH v3 09/12] scsi/ncr5380: Pass hostdata pointer to register polling routines Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` [PATCH v3 08/12] scsi/ncr5380: Use correct types for device register accessors Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 9:13 ` Russell King - ARM Linux
2016-10-10 9:13 ` Russell King - ARM Linux
2016-10-10 9:13 ` Russell King - ARM Linux
2016-10-10 4:46 ` [PATCH v3 06/12] scsi/ncr5380: Improve hostdata struct member alignment and cache-ability Finn Thain
2016-10-10 4:46 ` Finn Thain
2016-10-10 4:46 ` [PATCH v3 12/12] scsi/ncr5380: Suppress unhelpful "interrupt without IRQ bit" message Finn Thain
2016-10-10 4:46 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010091949.GZ1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=fthain@telegraphics.com.au \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.