All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH]btrfs-progs: btrfs-debugfs: cleanup unused variables reported by pylint
@ 2016-10-10 12:04 Lakshmipathi.G
  2016-10-10 15:04 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Lakshmipathi.G @ 2016-10-10 12:04 UTC (permalink / raw)
  To: linux-btrfs

Signed-off-by: Lakshmipathi.G <Lakshmipathi.G@giis.co.in>
---
 btrfs-debugfs | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/btrfs-debugfs b/btrfs-debugfs
index 0a654a6..dfb8853 100755
--- a/btrfs-debugfs
+++ b/btrfs-debugfs
@@ -4,7 +4,7 @@
 # LGPLv2 license
 # Copyright Facebook 2014
 
-import sys,os,struct,fcntl,ctypes,stat,argparse
+import sys, os, fcntl, ctypes, stat, argparse
 
 # helpers for max ints
 maxu64 = (1L << 64) - 1
@@ -233,7 +233,6 @@ def print_file_extents(filename):
     s.args.min_objectid = st.st_ino
     s.args.max_objectid = st.st_ino
 
-    size = st.st_size
 
     while True:
         try:
@@ -314,7 +313,7 @@ def print_block_groups(mountpoint):
 
     try:
         fd = os.open(mountpoint, os.O_RDONLY)
-        st = os.fstat(fd)
+        os.fstat(fd)
     except Exception, e:
         sys.stderr.write("Failed to open %s (%s)\n" % (mountpoint, e))
         return -1
@@ -336,7 +335,7 @@ def print_block_groups(mountpoint):
         h = ctypes.addressof(header)
         p_left = args_buffer_size
 
-        for x in xrange(0, s.args.nr_items):
+        for _ in xrange(0, s.args.nr_items):
             # for each itme, copy the header from the buffer into
             # our header struct
             ctypes.memmove(h, p, header_size)
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH]btrfs-progs: btrfs-debugfs: cleanup unused variables reported by pylint
  2016-10-10 12:04 [PATCH]btrfs-progs: btrfs-debugfs: cleanup unused variables reported by pylint Lakshmipathi.G
@ 2016-10-10 15:04 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2016-10-10 15:04 UTC (permalink / raw)
  To: Lakshmipathi.G; +Cc: linux-btrfs

On Mon, Oct 10, 2016 at 02:04:55PM +0200, Lakshmipathi.G wrote:
> Signed-off-by: Lakshmipathi.G <Lakshmipathi.G@giis.co.in>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-10 15:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-10 12:04 [PATCH]btrfs-progs: btrfs-debugfs: cleanup unused variables reported by pylint Lakshmipathi.G
2016-10-10 15:04 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.