From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] PCI: aardvark: Name private struct pointer "advk" consistently
Date: Mon, 10 Oct 2016 12:16:30 -0500 [thread overview]
Message-ID: <20161010171630.GA12748@localhost> (raw)
In-Reply-To: <20161007220734.5f43e444@free-electrons.com>
Hi Thomas,
On Fri, Oct 07, 2016 at 10:07:34PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Fri, 07 Oct 2016 11:20:53 -0500, Bjorn Helgaas wrote:
> > Use a device-specific name, "advk", for struct advk_pcie pointers to hint
> > that this is device-specific information. No functional change intended.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> > drivers/pci/host/pci-aardvark.c | 370 +++++++++++++++++++--------------------
> > 1 file changed, 183 insertions(+), 187 deletions(-)
>
> For the entire series:
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sorry to iterate on this even more, but I renamed the local variables
from "advk" to "advk_pcie" since some of these are SoCs with drivers
other than just PCI, and I renamed "advk_readl" to "advk_pcie_readl"
similarly. I repushed the branch.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] PCI: aardvark: Name private struct pointer "advk" consistently
Date: Mon, 10 Oct 2016 12:16:30 -0500 [thread overview]
Message-ID: <20161010171630.GA12748@localhost> (raw)
In-Reply-To: <20161007220734.5f43e444@free-electrons.com>
Hi Thomas,
On Fri, Oct 07, 2016 at 10:07:34PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Fri, 07 Oct 2016 11:20:53 -0500, Bjorn Helgaas wrote:
> > Use a device-specific name, "advk", for struct advk_pcie pointers to hint
> > that this is device-specific information. No functional change intended.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> > drivers/pci/host/pci-aardvark.c | 370 +++++++++++++++++++--------------------
> > 1 file changed, 183 insertions(+), 187 deletions(-)
>
> For the entire series:
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sorry to iterate on this even more, but I renamed the local variables
from "advk" to "advk_pcie" since some of these are SoCs with drivers
other than just PCI, and I renamed "advk_readl" to "advk_pcie_readl"
similarly. I repushed the branch.
Bjorn
next prev parent reply other threads:[~2016-10-10 17:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 16:20 [PATCH 1/5] PCI: aardvark: Name private struct pointer "advk" consistently Bjorn Helgaas
2016-10-07 16:20 ` Bjorn Helgaas
2016-10-07 16:21 ` [PATCH 2/5] PCI: aardvark: Reorder accessor functions Bjorn Helgaas
2016-10-07 16:21 ` Bjorn Helgaas
2016-10-07 16:21 ` [PATCH 3/5] PCI: aardvark: Swap order of advk_write() reg/val arguments Bjorn Helgaas
2016-10-07 16:21 ` Bjorn Helgaas
2016-10-07 16:21 ` [PATCH 4/5] PCI: aardvark: Add local struct device pointers Bjorn Helgaas
2016-10-07 16:21 ` Bjorn Helgaas
2016-10-07 16:21 ` [PATCH 5/5] PCI: aardvark: Remove unused platform data Bjorn Helgaas
2016-10-07 16:21 ` Bjorn Helgaas
2016-10-07 20:07 ` [PATCH 1/5] PCI: aardvark: Name private struct pointer "advk" consistently Thomas Petazzoni
2016-10-07 20:07 ` Thomas Petazzoni
2016-10-10 17:16 ` Bjorn Helgaas [this message]
2016-10-10 17:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010171630.GA12748@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.