* [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue
@ 2016-10-11 19:49 Nadim Almas
2016-10-12 13:25 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Nadim Almas @ 2016-10-11 19:49 UTC (permalink / raw)
To: hvaibhav.linux, johan; +Cc: devel, linux-kernel
fixed trailing */ Block comments and 80 character line limit coding style issue
Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
drivers/staging/greybus/arche-apb-ctrl.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c
index 70323aa..eeba912 100644
--- a/drivers/staging/greybus/arche-apb-ctrl.c
+++ b/drivers/staging/greybus/arche-apb-ctrl.c
@@ -168,7 +168,10 @@ static int standby_boot_seq(struct platform_device *pdev)
if (apb->init_disabled)
return 0;
- /* Even if it is in OFF state, then we do not want to change the state */
+ /*
+ * Even if it is in OFF state,
+ * then we do not want to change the state
+ */
if (apb->state == ARCHE_PLATFORM_STATE_STANDBY ||
apb->state == ARCHE_PLATFORM_STATE_OFF)
return 0;
@@ -183,7 +186,7 @@ static int standby_boot_seq(struct platform_device *pdev)
* Pasted from WDM spec,
* - A falling edge on POWEROFF_L is detected (a)
* - WDM enters standby mode, but no output signals are changed
- * */
+ */
/* TODO: POWEROFF_L is input to WDM module */
apb->state = ARCHE_PLATFORM_STATE_STANDBY;
@@ -286,7 +289,8 @@ static ssize_t state_store(struct device *dev,
return count;
/* First we want to make sure we power off everything
- * and then enter FW flashing state */
+ * and then enter FW flashing state
+ */
poweroff_seq(pdev);
ret = fw_flashing_seq(pdev);
} else {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue
2016-10-11 19:49 [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue Nadim Almas
@ 2016-10-12 13:25 ` Greg KH
2016-10-12 14:03 ` Nadim Almas
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-10-12 13:25 UTC (permalink / raw)
To: Nadim Almas; +Cc: hvaibhav.linux, johan, devel, linux-kernel
On Tue, Oct 11, 2016 at 12:49:54PM -0700, Nadim Almas wrote:
> fixed trailing */ Block comments and 80 character line limit coding style issue
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
Someone else already sent this same patch in before you, sorry :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue
2016-10-12 13:25 ` Greg KH
@ 2016-10-12 14:03 ` Nadim Almas
2016-10-12 14:45 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Nadim Almas @ 2016-10-12 14:03 UTC (permalink / raw)
To: Greg KH; +Cc: hvaibhav.linux, johan, devel, linux-kernel
>Someone else already sent this same patch in before you, sorry
But sir how can i come to know that Someone else already sent
particular patch before sending that particular patch
On Wed, Oct 12, 2016 at 6:55 PM, Greg KH <greg@kroah.com> wrote:
> On Tue, Oct 11, 2016 at 12:49:54PM -0700, Nadim Almas wrote:
>> fixed trailing */ Block comments and 80 character line limit coding style issue
>>
>> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
>> ---
>
> Someone else already sent this same patch in before you, sorry :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue
2016-10-12 14:03 ` Nadim Almas
@ 2016-10-12 14:45 ` Greg KH
2016-10-13 4:00 ` Alexander Alemayhu
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-10-12 14:45 UTC (permalink / raw)
To: Nadim Almas; +Cc: hvaibhav.linux, johan, devel, linux-kernel
On Wed, Oct 12, 2016 at 07:33:07PM +0530, Nadim Almas wrote:
> >Someone else already sent this same patch in before you, sorry
> But sir how can i come to know that Someone else already sent
> particular patch before sending that particular patch
You can subscribe to the driverdev mailing list to see what othes are
working on, and you can follow my staging-testing kernel branch in the
staging.git tree. But sometimes you just get unlucky, lots of people
are working on cleaning up staging drivers, people do the same work at
the same time quite often, it's just part of the process.
Pick something else to work on, we have lots of things to do :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue
2016-10-12 14:45 ` Greg KH
@ 2016-10-13 4:00 ` Alexander Alemayhu
2016-10-13 7:08 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Alemayhu @ 2016-10-13 4:00 UTC (permalink / raw)
To: Greg KH; +Cc: Nadim Almas, hvaibhav.linux, johan, devel, linux-kernel
On Wed, Oct 12, 2016 at 04:45:54PM +0200, Greg KH wrote:
>
> You can subscribe to the driverdev mailing list to see what othes are
> working on, and you can follow my staging-testing kernel branch in the
> staging.git tree. But sometimes you just get unlucky, lots of people
> are working on cleaning up staging drivers, people do the same work at
> the same time quite often, it's just part of the process.
>
Is this
(http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel)
the right page for subscribing?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue
2016-10-13 4:00 ` Alexander Alemayhu
@ 2016-10-13 7:08 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2016-10-13 7:08 UTC (permalink / raw)
To: Alexander Alemayhu
Cc: Nadim Almas, hvaibhav.linux, johan, devel, linux-kernel
On Thu, Oct 13, 2016 at 06:00:45AM +0200, Alexander Alemayhu wrote:
> On Wed, Oct 12, 2016 at 04:45:54PM +0200, Greg KH wrote:
> >
> > You can subscribe to the driverdev mailing list to see what othes are
> > working on, and you can follow my staging-testing kernel branch in the
> > staging.git tree. But sometimes you just get unlucky, lots of people
> > are working on cleaning up staging drivers, people do the same work at
> > the same time quite often, it's just part of the process.
> >
>
> Is this
> (http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel)
> the right page for subscribing?
Yes.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-13 7:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-11 19:49 [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue Nadim Almas
2016-10-12 13:25 ` Greg KH
2016-10-12 14:03 ` Nadim Almas
2016-10-12 14:45 ` Greg KH
2016-10-13 4:00 ` Alexander Alemayhu
2016-10-13 7:08 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.