From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] rxrpc: Add IPv6 support
Date: Wed, 12 Oct 2016 06:11:18 +0000 [thread overview]
Message-ID: <20161012061118.GI12841@mwanda> (raw)
Hello David Howells,
The patch 75b54cb57ca3: "rxrpc: Add IPv6 support" from Sep 13, 2016,
leads to the following static checker warning:
net/rxrpc/peer_object.c:196 rxrpc_assess_MTU_size()
warn: 'dst' isn't an ERR_PTR
net/rxrpc/peer_object.c
193 fl6->fl6_dport = htons(7001);
194 fl6->fl6_sport = htons(7000);
195 dst = ip6_route_output(&init_net, NULL, fl6);
196 if (IS_ERR(dst)) {
^^^^^^^^^^^
Maybe you want to check dst->error?
197 _leave(" [route err %ld]", PTR_ERR(dst));
198 return;
199 }
200 break;
regards,
dan carpenter
next reply other threads:[~2016-10-12 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 6:11 Dan Carpenter [this message]
2016-10-12 7:26 ` [bug report] rxrpc: Add IPv6 support David Howells
2016-10-12 8:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012061118.GI12841@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.