From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] rxrpc: Add IPv6 support
Date: Wed, 12 Oct 2016 08:31:39 +0000 [thread overview]
Message-ID: <20161012083139.GF5630@mwanda> (raw)
In-Reply-To: <20161012061118.GI12841@mwanda>
On Wed, Oct 12, 2016 at 08:26:01AM +0100, David Howells wrote:
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > 196 if (IS_ERR(dst)) {
> > ^^^^^^^^^^^
> > Maybe you want to check dst->error?
>
> Hmmm... Why don't I see this when I run checker, I wonder?
>
I haven't released this one because people do all kinds of nonsense
checks for IS_ERR() out of paranoia.
regards,
dan carpenter
prev parent reply other threads:[~2016-10-12 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 6:11 [bug report] rxrpc: Add IPv6 support Dan Carpenter
2016-10-12 7:26 ` David Howells
2016-10-12 8:31 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012083139.GF5630@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.