From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sangseok Lee <sangseok.lee@lge.com>
Subject: Re: [PATCH v2 4/4] mm: make unreserve highatomic functions reliable
Date: Wed, 12 Oct 2016 16:48:38 +0900 [thread overview]
Message-ID: <20161012074838.GA7688@bbox> (raw)
In-Reply-To: <20161012073328.GC9504@dhcp22.suse.cz>
On Wed, Oct 12, 2016 at 09:33:28AM +0200, Michal Hocko wrote:
> On Wed 12-10-16 14:33:36, Minchan Kim wrote:
> [...]
> > @@ -2138,8 +2146,10 @@ static bool unreserve_highatomic_pageblock(const struct alloc_context *ac)
> > */
> > set_pageblock_migratetype(page, ac->migratetype);
> > ret = move_freepages_block(zone, page, ac->migratetype);
> > - spin_unlock_irqrestore(&zone->lock, flags);
> > - return ret;
> > + if (!drain && ret) {
> > + spin_unlock_irqrestore(&zone->lock, flags);
> > + return ret;
> > + }
>
> I've already mentioned that during the previous discussion. This sounds
Yeb, we did but I sent wrong version in my git tree. :(
> overly aggressive to me. Why do we want to drain the whole reserve and
> risk that we won't be able to build up a new one after OOM. Doing one
> block at the time should be sufficient IMHO.
I will resend with updating with every reveiw points.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
Sangseok Lee <sangseok.lee@lge.com>
Subject: Re: [PATCH v2 4/4] mm: make unreserve highatomic functions reliable
Date: Wed, 12 Oct 2016 16:48:38 +0900 [thread overview]
Message-ID: <20161012074838.GA7688@bbox> (raw)
In-Reply-To: <20161012073328.GC9504@dhcp22.suse.cz>
On Wed, Oct 12, 2016 at 09:33:28AM +0200, Michal Hocko wrote:
> On Wed 12-10-16 14:33:36, Minchan Kim wrote:
> [...]
> > @@ -2138,8 +2146,10 @@ static bool unreserve_highatomic_pageblock(const struct alloc_context *ac)
> > */
> > set_pageblock_migratetype(page, ac->migratetype);
> > ret = move_freepages_block(zone, page, ac->migratetype);
> > - spin_unlock_irqrestore(&zone->lock, flags);
> > - return ret;
> > + if (!drain && ret) {
> > + spin_unlock_irqrestore(&zone->lock, flags);
> > + return ret;
> > + }
>
> I've already mentioned that during the previous discussion. This sounds
Yeb, we did but I sent wrong version in my git tree. :(
> overly aggressive to me. Why do we want to drain the whole reserve and
> risk that we won't be able to build up a new one after OOM. Doing one
> block at the time should be sufficient IMHO.
I will resend with updating with every reveiw points.
Thanks.
next prev parent reply other threads:[~2016-10-12 7:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 5:33 [PATCH v2 0/4] use up highorder free pages before OOM Minchan Kim
2016-10-12 5:33 ` Minchan Kim
2016-10-12 5:33 ` [PATCH v2 1/4] mm: don't steal highatomic pageblock Minchan Kim
2016-10-12 5:33 ` Minchan Kim
2016-10-12 5:33 ` [PATCH v2 2/4] mm: prevent double decrease of nr_reserved_highatomic Minchan Kim
2016-10-12 5:33 ` Minchan Kim
2016-10-12 5:33 ` [PATCH v2 3/4] mm: try to exhaust highatomic reserve before the OOM Minchan Kim
2016-10-12 5:33 ` Minchan Kim
2016-10-12 7:14 ` Vlastimil Babka
2016-10-12 7:14 ` Vlastimil Babka
2016-10-12 7:24 ` Michal Hocko
2016-10-12 7:24 ` Michal Hocko
2016-10-12 5:33 ` [PATCH v2 4/4] mm: make unreserve highatomic functions reliable Minchan Kim
2016-10-12 5:33 ` Minchan Kim
2016-10-12 7:19 ` Vlastimil Babka
2016-10-12 7:19 ` Vlastimil Babka
2016-10-12 7:33 ` Michal Hocko
2016-10-12 7:33 ` Michal Hocko
2016-10-12 7:48 ` Minchan Kim [this message]
2016-10-12 7:48 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012074838.GA7688@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=sangseok.lee@lge.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.