[PATCH 0/7 v2] nvme-fabrics: Add FC-NVME Transport support

[PATCH 0/7 v2] nvme-fabrics: Add FC-NVME Transport support

[James Smart]

The patches in this set add support for the FC transport to the nvme
fabrics subsystem.  The set include header files with T11 transport
definitions and an api for the FC-NVME transport to talk with FC LLDDs.
It also includes host and target transport files. A FC loopback driver
is supplied to act as a FC LLDD to exercise the api.

The patchset addresses the prior review comments. The largest impact
was the teardown paths and proper ref counting support.

Revised for review comments from earlier this week.

The patches were cut against the linux-block.git tree, for-next branch
as of 10/3 and are dependent on the following patches:

add u64 number parser
http://lists.infradead.org/pipermail/linux-nvme/2016-September/006371.html

patch tgt code for FC transport
http://lists.infradead.org/pipermail/linux-nvme/2016-September/006387.html

set sqe.command_id in core not transports
http://lists.infradead.org/pipermail/linux-nvme/2016-September/006386.html


-- james



James Smart (7):
  Add type 0x28 NVME type code to scsi fc headers
  nvme-fabrics: Add FC transport error codes to nvme.h
  nvme-fabrics: Add FC transport FC-NVME definitions
  nvme-fabrics: Add FC transport LLDD api definitions
  nvme-fabrics: Add host FC transport support
  nvme-fabrics: Add target FC transport support
  nvme-fabrics: Add FC LLDD loopback driver to test FC-NVME

 drivers/nvme/host/Kconfig      |   16 +
 drivers/nvme/host/Makefile     |    3 +
 drivers/nvme/host/fc.c         | 2304 ++++++++++++++++++++++++++++++++++++++++
 drivers/nvme/target/Kconfig    |   23 +
 drivers/nvme/target/Makefile   |    4 +
 drivers/nvme/target/fc.c       | 1976 ++++++++++++++++++++++++++++++++++
 drivers/nvme/target/fcloop.c   | 1142 ++++++++++++++++++++
 include/linux/nvme-fc-driver.h |  834 +++++++++++++++
 include/linux/nvme-fc.h        |  255 +++++
 include/linux/nvme.h           |   20 +
 include/uapi/scsi/fc/fc_fs.h   |    2 +
 11 files changed, 6579 insertions(+)
 create mode 100644 drivers/nvme/host/fc.c
 create mode 100644 drivers/nvme/target/fc.c
 create mode 100644 drivers/nvme/target/fcloop.c
 create mode 100644 include/linux/nvme-fc-driver.h
 create mode 100644 include/linux/nvme-fc.h

-- 
2.5.0

[PATCH 0/7 v2] nvme-fabrics: Add FC-NVME Transport support

[Christoph Hellwig]

On Fri, Oct 07, 2016@04:09:01PM -0700, James Smart wrote:
> 
> The patches in this set add support for the FC transport to the nvme
> fabrics subsystem.  The set include header files with T11 transport
> definitions and an api for the FC-NVME transport to talk with FC LLDDs.
> It also includes host and target transport files. A FC loopback driver
> is supplied to act as a FC LLDD to exercise the api.

What's the timeline for submitting the lpfc support?  Even if you're
not submitting it quite yet having it available somewhere as a reference
would be really useful when reviewing the code.

Also the code makes git-am complain:

Applying: nvme-fabrics: Add FC transport FC-NVME definitions
/home/hch/work/linux/.git/rebase-apply/patch:266: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: nvme-fabrics: Add FC transport LLDD api definitions
/home/hch/work/linux/.git/rebase-apply/patch:845: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: nvme-fabrics: Add host FC transport support
/home/hch/work/linux/.git/rebase-apply/patch:2359: new blank line at
EOF.
+
warning: 1 line adds whitespace errors.
Applying: nvme-fabrics: Add target FC transport support
/home/hch/work/linux/.git/rebase-apply/patch:25: new blank line at EOF.
+
/home/hch/work/linux/.git/rebase-apply/patch:2020: new blank line at
EOF.
+
warning: 2 lines add whitespace errors.
Applying: nvme-fabrics: Add FC LLDD loopback driver to test FC-NVME
/home/hch/work/linux/.git/rebase-apply/patch:1190: new blank line at
EOF.
+

[PATCH 0/7 v2] nvme-fabrics: Add FC-NVME Transport support

[James Smart]

On 10/12/2016 1:53 AM, Christoph Hellwig wrote:
> On Fri, Oct 07, 2016@04:09:01PM -0700, James Smart wrote:
>> The patches in this set add support for the FC transport to the nvme
>> fabrics subsystem.  The set include header files with T11 transport
>> definitions and an api for the FC-NVME transport to talk with FC LLDDs.
>> It also includes host and target transport files. A FC loopback driver
>> is supplied to act as a FC LLDD to exercise the api.
> What's the timeline for submitting the lpfc support?  Even if you're
> not submitting it quite yet having it available somewhere as a reference
> would be really useful when reviewing the code.

I've already submitted lpfc nvme support once with the prior transport 
posting. Look on linux-nvme as well as linux-scsi and look for the 
11.2.0.1 patch set.  I'm wrapping up the repost of it with this new 
transport posting now. It'll be based on a lpfc update that I'm posting 
momentarilly. So, within a day or two.


>
> Also the code makes git-am complain:
not sure what's generating this.  Everything is pre-checked vs 
Checkpatch. I'll look closer.

-- james