From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 3/7 v2] nvme-fabrics: Add FC transport FC-NVME definitions
Date: Wed, 12 Oct 2016 01:58:34 -0700 [thread overview]
Message-ID: <20161012085834.GD12972@infradead.org> (raw)
In-Reply-To: <57f82b10.h/qKXTOsgeHQsdmh%james.smart@broadcom.com>
On Fri, Oct 07, 2016@04:09:04PM -0700, James Smart wrote:
>
> nvme-fabrics: Add FC transport FC-NVME definitions:
FYI, all the patches seem to have this duplicate of the subject in
the mail body.
> - cmd_iu changed in T11. The 2 reserved words, previous at words
> 2 and 3, were moved to after the sqe.
> - Modifications from prior reviews:
> - FC-transport-specific error codes moved to include/linux/nvme.h
> - Removed 0x28 type declaration to include/uapi/scsi/fc/fc_fs.h
> - Removed Reject reasons and explanations. ELS values are to be used.
This should go either into the cover letter, or below the "---" line
so that it doesn't show up in the commit message.
> +/* fills in length of a descriptor. Struture minus descriptor header */
> +#define FCNVME_LSDESC_LEN(lsdesc) \
> + cpu_to_be32(sizeof(lsdesc) - (2*(sizeof(u32))))
Make this an inline function and use spaces between the operators,
please.
Except for these nitpicks the patch looks fine to me:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2016-10-12 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 23:09 [PATCH 3/7 v2] nvme-fabrics: Add FC transport FC-NVME definitions James Smart
2016-10-12 8:58 ` Christoph Hellwig [this message]
2016-10-12 18:53 ` James Smart
2016-10-13 9:15 ` Christoph Hellwig
2016-10-18 17:59 ` James Smart
2016-10-18 19:49 ` Jon Derrick
2016-10-18 22:20 ` James Smart
2016-10-18 23:32 ` Jon Derrick
2016-10-19 12:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012085834.GD12972@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.