From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 3/7 v2] nvme-fabrics: Add FC transport FC-NVME definitions
Date: Thu, 13 Oct 2016 02:15:00 -0700 [thread overview]
Message-ID: <20161013091500.GA16162@infradead.org> (raw)
In-Reply-To: <e98579b7-2b6a-8987-0ced-a0146ea5919b@broadcom.com>
On Wed, Oct 12, 2016@11:53:29AM -0700, James Smart wrote:
> Ok - help my style. I assumed deltas to original patch made sense to
> itemize. As they are specific to this one file I thought it made sense to be
> in the commit message for this patch. I have no problem moving it to the
> cover letter. Just not sure what the criteria is for one place vs another.
If you want to keep them in this patch that's not as usual but okay as
well. But in that case move it under the '---' marker, so that git-am
won't pick it up.
next prev parent reply other threads:[~2016-10-13 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 23:09 [PATCH 3/7 v2] nvme-fabrics: Add FC transport FC-NVME definitions James Smart
2016-10-12 8:58 ` Christoph Hellwig
2016-10-12 18:53 ` James Smart
2016-10-13 9:15 ` Christoph Hellwig [this message]
2016-10-18 17:59 ` James Smart
2016-10-18 19:49 ` Jon Derrick
2016-10-18 22:20 ` James Smart
2016-10-18 23:32 ` Jon Derrick
2016-10-19 12:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013091500.GA16162@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.