* [patch] PCI: rockchip: Indent an if statement
@ 2016-10-12 10:54 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-10-12 10:54 UTC (permalink / raw)
To: Shawn Lin
Cc: Wenrui Li, Bjorn Helgaas, Heiko Stuebner, linux-pci,
linux-rockchip, kernel-janitors
The if statement wasn't intended. Add a tab.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index b8c82fc..f54ef1e 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
return -EINVAL;
if (region_no = 0) {
if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
- return -EINVAL;
+ return -EINVAL;
}
if (region_no != 0) {
if (AXI_REGION_SIZE < (2ULL << num_pass_bits))
^ permalink raw reply related [flat|nested] 8+ messages in thread* [patch] PCI: rockchip: Indent an if statement
@ 2016-10-12 10:54 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-10-12 10:54 UTC (permalink / raw)
To: Shawn Lin
Cc: Wenrui Li, Bjorn Helgaas, Heiko Stuebner, linux-pci,
linux-rockchip, kernel-janitors
The if statement wasn't intended. Add a tab.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index b8c82fc..f54ef1e 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
return -EINVAL;
if (region_no == 0) {
if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
- return -EINVAL;
+ return -EINVAL;
}
if (region_no != 0) {
if (AXI_REGION_SIZE < (2ULL << num_pass_bits))
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [patch] PCI: rockchip: Indent an if statement
2016-10-12 10:54 ` Dan Carpenter
(?)
@ 2016-10-12 11:04 ` Shawn Lin
-1 siblings, 0 replies; 8+ messages in thread
From: Shawn Lin @ 2016-10-12 11:04 UTC (permalink / raw)
To: Dan Carpenter, Shawn Lin
Cc: Heiko Stuebner, linux-pci, Wenrui Li, kernel-janitors,
linux-rockchip, Bjorn Helgaas
On 2016/10/12 18:54, Dan Carpenter wrote:
> The if statement wasn't intended. Add a tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for this patch.
Currently the driver is under cleanup, so it would be fine
for Bjorn to pick it up for host-rockchip branch. :)
>
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index b8c82fc..f54ef1e 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
> return -EINVAL;
> if (region_no = 0) {
> if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
> - return -EINVAL;
> + return -EINVAL;
> }
> if (region_no != 0) {
> if (AXI_REGION_SIZE < (2ULL << num_pass_bits))
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] PCI: rockchip: Indent an if statement
@ 2016-10-12 11:04 ` Shawn Lin
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Lin @ 2016-10-12 11:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: shawn.lin, Heiko Stuebner, linux-pci, Wenrui Li, kernel-janitors,
linux-rockchip, Bjorn Helgaas
On 2016/10/12 18:54, Dan Carpenter wrote:
> The if statement wasn't intended. Add a tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for this patch.
Currently the driver is under cleanup, so it would be fine
for Bjorn to pick it up for host-rockchip branch. :)
>
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index b8c82fc..f54ef1e 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
> return -EINVAL;
> if (region_no == 0) {
> if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
> - return -EINVAL;
> + return -EINVAL;
> }
> if (region_no != 0) {
> if (AXI_REGION_SIZE < (2ULL << num_pass_bits))
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] PCI: rockchip: Indent an if statement
@ 2016-10-12 11:04 ` Shawn Lin
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Lin @ 2016-10-12 11:04 UTC (permalink / raw)
To: Dan Carpenter, Shawn Lin
Cc: shawn.lin, Heiko Stuebner, linux-pci, Wenrui Li, kernel-janitors,
linux-rockchip, Bjorn Helgaas
On 2016/10/12 18:54, Dan Carpenter wrote:
> The if statement wasn't intended. Add a tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for this patch.
Currently the driver is under cleanup, so it would be fine
for Bjorn to pick it up for host-rockchip branch. :)
>
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index b8c82fc..f54ef1e 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
> return -EINVAL;
> if (region_no == 0) {
> if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
> - return -EINVAL;
> + return -EINVAL;
> }
> if (region_no != 0) {
> if (AXI_REGION_SIZE < (2ULL << num_pass_bits))
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] PCI: rockchip: Indent an if statement
2016-10-12 10:54 ` Dan Carpenter
(?)
@ 2016-10-12 12:18 ` Bjorn Helgaas
-1 siblings, 0 replies; 8+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Shawn Lin, Wenrui Li, Bjorn Helgaas, Heiko Stuebner, linux-pci,
linux-rockchip, kernel-janitors
On Wed, Oct 12, 2016 at 01:54:09PM +0300, Dan Carpenter wrote:
> The if statement wasn't intended. Add a tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to pci/host-rockchip for v4.9, thanks, Dan.
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index b8c82fc..f54ef1e 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
> return -EINVAL;
> if (region_no = 0) {
> if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
> - return -EINVAL;
> + return -EINVAL;
> }
> if (region_no != 0) {
> if (AXI_REGION_SIZE < (2ULL << num_pass_bits))
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] PCI: rockchip: Indent an if statement
@ 2016-10-12 12:18 ` Bjorn Helgaas
0 siblings, 0 replies; 8+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Heiko Stuebner, linux-pci-u79uwXL29TY76Z2rM5mHXA, Shawn Lin,
Wenrui Li, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Bjorn Helgaas
On Wed, Oct 12, 2016 at 01:54:09PM +0300, Dan Carpenter wrote:
> The if statement wasn't intended. Add a tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Applied to pci/host-rockchip for v4.9, thanks, Dan.
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index b8c82fc..f54ef1e 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
> return -EINVAL;
> if (region_no == 0) {
> if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
> - return -EINVAL;
> + return -EINVAL;
> }
> if (region_no != 0) {
> if (AXI_REGION_SIZE < (2ULL << num_pass_bits))
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] PCI: rockchip: Indent an if statement
@ 2016-10-12 12:18 ` Bjorn Helgaas
0 siblings, 0 replies; 8+ messages in thread
From: Bjorn Helgaas @ 2016-10-12 12:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Shawn Lin, Wenrui Li, Bjorn Helgaas, Heiko Stuebner, linux-pci,
linux-rockchip, kernel-janitors
On Wed, Oct 12, 2016 at 01:54:09PM +0300, Dan Carpenter wrote:
> The if statement wasn't intended. Add a tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to pci/host-rockchip for v4.9, thanks, Dan.
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index b8c82fc..f54ef1e 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
> return -EINVAL;
> if (region_no == 0) {
> if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
> - return -EINVAL;
> + return -EINVAL;
> }
> if (region_no != 0) {
> if (AXI_REGION_SIZE < (2ULL << num_pass_bits))
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-12 12:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 10:54 [patch] PCI: rockchip: Indent an if statement Dan Carpenter
2016-10-12 10:54 ` Dan Carpenter
2016-10-12 11:04 ` Shawn Lin
2016-10-12 11:04 ` Shawn Lin
2016-10-12 11:04 ` Shawn Lin
2016-10-12 12:18 ` Bjorn Helgaas
2016-10-12 12:18 ` Bjorn Helgaas
2016-10-12 12:18 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.