* [PATCH] Staging: media: tw686x-kh: Fix comment block coding style
@ 2016-10-11 7:59 Mihaela Muraru
2016-10-12 13:14 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Mihaela Muraru @ 2016-10-11 7:59 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: outreachy-kernel
This is a patch to the tw686x-kh-video.c file that fixes up a comment
block warning, found by checkpatch.pl tool, by adding a * for each line
of the comment block.
Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
---
drivers/staging/media/tw686x-kh/tw686x-kh-video.c | 48 +++++++++++++----------
1 file changed, 27 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/media/tw686x-kh/tw686x-kh-video.c b/drivers/staging/media/tw686x-kh/tw686x-kh-video.c
index 9bf32ae..19cf31a 100644
--- a/drivers/staging/media/tw686x-kh/tw686x-kh-video.c
+++ b/drivers/staging/media/tw686x-kh/tw686x-kh-video.c
@@ -221,20 +221,20 @@ loop:
vc->curr_bufs[n] = NULL;
}
-/* On TW6864 and TW6868, all channels share the pair of video DMA SG tables,
- with 10-bit start_idx and end_idx determining start and end of frame buffer
- for particular channel.
- TW6868 with all its 8 channels would be problematic (only 127 SG entries per
- channel) but we support only 4 channels on this chip anyway (the first
- 4 channels are driven with internal video decoder, the other 4 would require
- an external TW286x part).
-
- On TW6865 and TW6869, each channel has its own DMA SG table, with indexes
- starting with 0. Both chips have complete sets of internal video decoders
- (respectively 4 or 8-channel).
-
- All chips have separate SG tables for two video frames. */
-
+/*
+ * On TW6864 and TW6868, all channels share the pair of video DMA SG tables
+ * with 10-bit start_idx and end_idx determining start and end of frame buffer
+ * for particular channel.
+ * TW6868 with all its 8 channels would be problematic (only 127 SG entries per
+ * channel) but we support only 4 channels on this chip anyway (the first
+ * 4 channels are driven with internal video decoder, the other 4 would require
+ * an external TW286x part).
+ *
+ * On TW6865 and TW6869, each channel has its own DMA SG table, with indexes
+ * starting with 0. Both chips have complete sets of internal video decoders
+ * (respectively 4 or 8-channel).
+ * All chips have separate SG tables for two video frames.
+ */
static void setup_dma_cfg(struct tw686x_video_channel *vc)
{
unsigned int field_width = 704;
@@ -477,8 +477,10 @@ static int tw686x_g_parm(struct file *file, void *priv,
static int tw686x_enum_input(struct file *file, void *priv,
struct v4l2_input *inp)
{
- /* the chip has internal multiplexer, support can be added
- if the actual hw uses it */
+ /*
+ * the chip has internal multiplexer, support can be added
+ * if the actual hw uses it
+ */
if (inp->index)
return -EINVAL;
@@ -675,16 +677,20 @@ int tw686x_kh_video_init(struct tw686x_dev *dev)
/* setup required SG table sizes */
for (n = 0; n < 2; n++)
if (is_second_gen(dev)) {
- /* TW 6865, TW6869 - each channel needs a pair of
- descriptor tables */
+ /*
+ * TW 6865, TW6869 - each channel needs a pair of
+ * descriptor tables
+ */
for (ch = 0; ch < max_channels(dev); ch++)
dev->video_channels[ch].sg_tables[n].size =
SG_TABLE_SIZE;
} else
- /* TW 6864, TW6868 - we need to allocate a pair of
- descriptor tables, common for all channels.
- Each table will be bigger than 4 KB. */
+ /*
+ * TW 6864, TW6868 - we need to allocate a pair of
+ * descriptor tables, common for all channels.
+ * Each table will be bigger than 4 KB.
+ */
dev->video_channels[0].sg_tables[n].size =
max_channels(dev) * SG_TABLE_SIZE;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: media: tw686x-kh: Fix comment block coding style
2016-10-11 7:59 [PATCH] Staging: media: tw686x-kh: Fix comment block coding style Mihaela Muraru
@ 2016-10-12 13:14 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2016-10-12 13:14 UTC (permalink / raw)
To: Mihaela Muraru; +Cc: outreachy-kernel
On Tue, Oct 11, 2016 at 10:59:46AM +0300, Mihaela Muraru wrote:
> This is a patch to the tw686x-kh-video.c file that fixes up a comment
> block warning, found by checkpatch.pl tool, by adding a * for each line
> of the comment block.
>
> Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> ---
> drivers/staging/media/tw686x-kh/tw686x-kh-video.c | 48 +++++++++++++----------
> 1 file changed, 27 insertions(+), 21 deletions(-)
This file is no longer in the kernel source tree :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-12 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-11 7:59 [PATCH] Staging: media: tw686x-kh: Fix comment block coding style Mihaela Muraru
2016-10-12 13:14 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.