From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [patch] drm/i915: fix a read size argument
Date: Thu, 13 Oct 2016 09:58:06 +0000 [thread overview]
Message-ID: <20161013095806.GL5630@mwanda> (raw)
In-Reply-To: <20161013090103.GC32528@nuc-i3427.alporthouse.com>
On Thu, Oct 13, 2016 at 10:01:03AM +0100, Chris Wilson wrote:
> On Thu, Oct 13, 2016 at 11:55:08AM +0300, Dan Carpenter wrote:
> > We want to read 3 bytes here, but because the parenthesis are in the
> > wrong place we instead read:
> >
> > sizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd)
> >
> > which is one byte.
> >
> > Fixes: fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Oops, does smatch catch this?
Yeah. It does.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [patch] drm/i915: fix a read size argument
Date: Thu, 13 Oct 2016 12:58:06 +0300 [thread overview]
Message-ID: <20161013095806.GL5630@mwanda> (raw)
In-Reply-To: <20161013090103.GC32528@nuc-i3427.alporthouse.com>
On Thu, Oct 13, 2016 at 10:01:03AM +0100, Chris Wilson wrote:
> On Thu, Oct 13, 2016 at 11:55:08AM +0300, Dan Carpenter wrote:
> > We want to read 3 bytes here, but because the parenthesis are in the
> > wrong place we instead read:
> >
> > sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)
> >
> > which is one byte.
> >
> > Fixes: fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Oops, does smatch catch this?
Yeah. It does.
regards,
dan carpenter
next prev parent reply other threads:[~2016-10-13 9:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 8:55 [patch] drm/i915: fix a read size argument Dan Carpenter
2016-10-13 8:55 ` Dan Carpenter
2016-10-13 8:55 ` Dan Carpenter
2016-10-13 9:01 ` [Intel-gfx] " Chris Wilson
2016-10-13 9:01 ` Chris Wilson
2016-10-13 9:01 ` Chris Wilson
2016-10-13 9:58 ` Dan Carpenter [this message]
2016-10-13 9:58 ` [Intel-gfx] " Dan Carpenter
2016-10-13 9:07 ` Eric Engestrom
2016-10-13 9:07 ` Eric Engestrom
2016-10-13 9:07 ` Eric Engestrom
2016-10-13 9:27 ` walter harms
2016-10-13 9:27 ` walter harms
2016-10-13 9:27 ` walter harms
2016-10-13 12:13 ` Jani Nikula
2016-10-13 12:13 ` Jani Nikula
2016-10-13 12:13 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013095806.GL5630@mwanda \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.