From: Mike Rapoport <mike.rapoport@gmail.com>
To: Edward Lipinsky <ellipinsky@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
sudip@vectorindia.org, teddy.wang@siliconmotion.com,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com
Subject: Re: [PATCH] staging: sm750fb: Fix printk() style warning
Date: Thu, 13 Oct 2016 14:39:22 +0000 [thread overview]
Message-ID: <20161013143922.GA17656@rapoport-lnx> (raw)
In-Reply-To: <20161010143146.GA8218@gmail.com>
On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote:
>
> Thanks, that makes sense. I tried deleting the if statement and printk()
> from ddk750_help.c, and adding the following in lynxfb_pci_probe() after
> calling hw_sm750_map() and checking for errors:
>
> if (sm750_dev->revid = 0xfe)
> dev_info(&pdev->dev, "found sm750le\n");
>
> The driver compiles, loads and unloads ok with this code.
>
> Does this look correct?
Yep, seems just right.
> Regards,
> Ed L.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <mike.rapoport@gmail.com>
To: Edward Lipinsky <ellipinsky@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
sudip@vectorindia.org, teddy.wang@siliconmotion.com,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com
Subject: Re: [PATCH] staging: sm750fb: Fix printk() style warning
Date: Thu, 13 Oct 2016 17:39:22 +0300 [thread overview]
Message-ID: <20161013143922.GA17656@rapoport-lnx> (raw)
In-Reply-To: <20161010143146.GA8218@gmail.com>
On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote:
>
> Thanks, that makes sense. I tried deleting the if statement and printk()
> from ddk750_help.c, and adding the following in lynxfb_pci_probe() after
> calling hw_sm750_map() and checking for errors:
>
> if (sm750_dev->revid == 0xfe)
> dev_info(&pdev->dev, "found sm750le\n");
>
> The driver compiles, loads and unloads ok with this code.
>
> Does this look correct?
Yep, seems just right.
> Regards,
> Ed L.
next prev parent reply other threads:[~2016-10-13 14:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 18:05 [PATCH] staging: sm750fb: Fix printk() style warning Edward Lipinsky
2016-10-02 18:05 ` Edward Lipinsky
2016-10-02 18:13 ` Greg KH
2016-10-02 18:13 ` Greg KH
2016-10-07 4:27 ` Edward Lipinsky
2016-10-07 4:27 ` Edward Lipinsky
2016-10-07 9:12 ` Mike Rapoport
2016-10-07 9:12 ` Mike Rapoport
2016-10-10 14:31 ` Edward Lipinsky
2016-10-10 14:31 ` Edward Lipinsky
2016-10-13 14:39 ` Mike Rapoport [this message]
2016-10-13 14:39 ` Mike Rapoport
2016-10-14 5:18 ` Edward Lipinsky
2016-10-14 5:18 ` Edward Lipinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013143922.GA17656@rapoport-lnx \
--to=mike.rapoport@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=ellipinsky@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudip@vectorindia.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.